Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
satisfies('1.2.3-alpha', '* || 1.2.3-alpha')currently returnsfalse, even though the explicit1.2.3-alphaalternative matches on its own. The range constructor reduces the whole expression to*, which excludes prereleases by default.Keep one wildcard and the alternatives containing prerelease bounds, preserving their order. Alternatives without prerelease bounds can still be dropped. With
includePrerelease: true, the wildcard already admits prereleases, so the expression still reduces to a wildcard.The regression fixtures cover both alternative orders, repeated wildcards, multiple prerelease alternatives, bounded prerelease ranges, ordinary releases, and rejection of other prereleases. The matching and formatting regressions fail against the original code and pass with this change.
On Windows with Node 24.19.0,
npm test --ignore-scriptspasses with 100% statement, branch, function and line coverage.npm run lint --ignore-scriptsandnpm run postlint --ignore-scriptsalso pass. The full CI platform and Node-version matrix has not been run locally.References
Fixes #906.
This follows the prerelease distinction described in the earlier discussion.