Skip to content

fix(core): forward environment updates to restarting plugin workers - #37064

Open
AgentEnder wants to merge 2 commits into
masterfrom
failing-nightlies-b900fd6c-worker-env
Open

AgentEnder wants to merge 2 commits into
masterfrom
failing-nightlies-b900fd6c-worker-env

Conversation

@AgentEnder

@AgentEnder AgentEnder commented Sep 15, 2026

Copy link
Copy Markdown
Member

Current Behavior

A plugin worker restarting during a client environment update misses the new values. The React Playwright nightly can then resolve its readiness URL from the previous environment.

Expected Behavior

Wait for the connecting worker before forwarding the environment update. Stopped workers remain stopped.

Related Issue(s)

Part of NXC-4945.


View Polygraph session ↗

@nx-cloud

nx-cloud Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f606315

Command Status Duration Result
nx affected --targets=lint,oxlint,test,build,e2... ✅ Succeeded 55m 11s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 56s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 18s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-16 16:20:37 UTC

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

@AgentEnder
AgentEnder force-pushed the failing-nightlies-b900fd6c-mf-yarn-workspaces branch from b36b5f8 to ce0f520 Compare September 16, 2026 15:01
@AgentEnder
AgentEnder force-pushed the failing-nightlies-b900fd6c-worker-env branch from 5d5c1de to 3795d23 Compare September 16, 2026 15:02
@AgentEnder
AgentEnder force-pushed the failing-nightlies-b900fd6c-mf-yarn-workspaces branch from ce0f520 to 5fe49a3 Compare September 16, 2026 15:11
@AgentEnder
AgentEnder changed the base branch from failing-nightlies-b900fd6c-mf-yarn-workspaces to master September 16, 2026 15:11
@AgentEnder
AgentEnder force-pushed the failing-nightlies-b900fd6c-worker-env branch from 3795d23 to f606315 Compare September 16, 2026 15:12
@polygraph-app
polygraph-app Bot marked this pull request as ready for review September 16, 2026 15:17
@polygraph-app
polygraph-app Bot requested a review from a team as a code owner September 16, 2026 15:17
@netlify

netlify Bot commented Sep 16, 2026

Copy link
Copy Markdown

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit f606315
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/6aaab1c8bdfb5a0008f0181d
😎 Deploy Preview https://deploy-preview-37064--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 16, 2026

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit f606315
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6aaab1c83f64870008167288
😎 Deploy Preview https://deploy-preview-37064--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AgentEnder AgentEnder added scope: core core nx functionality type: bug labels Sep 20, 2026
@AgentEnder AgentEnder self-assigned this Sep 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant