Skip to content

fix(core): avoid full resolves for window environment reports - #1000

Merged
houko merged 1 commit into
mainfrom
assess/issue178-env-diff
Nov 20, 2026
Merged

houko merged 1 commit into
mainfrom
assess/issue178-env-diff

Conversation

@houko

@houko houko commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep WindowFrame, Maximized, Lifecycle, and TitleBar reports on the signal-driven incremental path
  • retain full environment resolution for fields the core reads directly while resolving or emitting
  • add regression coverage for incremental window reports and full-round fields

Window moves and title-bar transitions no longer force a whole-tree resolve when no node reads those environment signals.

Verification

  • go tool nsgo test -run 'TestWindowEnvironment' -timeout 3m
  • go tool nsgo check -jobs 2

Closes #178

@github-actions github-actions Bot added the core label Nov 20, 2026
@houko houko changed the title Avoid full resolves for window environment reports fix(core): avoid full resolves for window environment reports Nov 20, 2026
@github-actions github-actions Bot added the bug Something isn't working label Nov 20, 2026
@houko
houko force-pushed the assess/issue178-env-diff branch from 7211705 to c63371d Compare November 20, 2026 14:42
@github-actions github-actions Bot added documentation Improvements or additions to documentation size/S size/M and removed size/S labels Nov 20, 2026
@houko
houko force-pushed the assess/issue178-env-diff branch from c63371d to 2a8b755 Compare November 20, 2026 15:02
@github-actions github-actions Bot removed the size/S label Nov 20, 2026
@houko
houko force-pushed the assess/issue178-env-diff branch from 2a8b755 to b597d61 Compare November 20, 2026 15:02
@houko

houko commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Reviewed.

  • Added the CHANGELOG bullet and flattened the wrapped comments.
  • Added a test that views reading WindowFrame, Maximized, Lifecycle and TitleBar through Env still update without a full round, and BenchmarkWindowMove (300 and 3000 rows): about 2 µs per move at both sizes, down from 460 µs and 14.7 ms.
  • Noted the exception in docs/architecture/core.md.
  • macOS target: a text reading Env().WindowFrame() follows SetWindowFrame.

@houko
houko force-pushed the assess/issue178-env-diff branch from b597d61 to 11863de Compare November 20, 2026 15:44
@houko
houko merged commit c06fa6f into main Nov 20, 2026
@houko
houko deleted the assess/issue178-env-diff branch November 20, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working core documentation Improvements or additions to documentation size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Every environment report marks the whole tree, so a window drag runs a full resolve and emit on each engine pass

1 participant