Repository navigation
fix(tsx): dispose entry mounts for view exports - #1003
Merged
Merged
Conversation
houko
force-pushed
the
assess/issue923-view-export
branch
2 times, most recently
from
November 20, 2026 15:02
bfdc2da to
52f3acc
Compare
houko
force-pushed
the
assess/issue923-view-export
branch
from
November 20, 2026 15:07
52f3acc to
9466b8c
Compare
houko
force-pushed
the
assess/issue923-view-export
branch
from
November 20, 2026 16:13
9466b8c to
57b508f
Compare
Collaborator
Author
|
Reviewed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mounthelperView.Export, removing their nodes and stopping effects, handlers, timers and animation framesVerification
go test ./tsx -run 'TestViewExportDisposesEntryMount|TestViewRendersNamedExportsWithIndependentState|TestViewRunsAVerifiedPackage' -count=1Closes #923