Repository navigation
fix(macos): normalize composited test screenshots - #1005
Merged
Merged
Conversation
4 tasks
houko
force-pushed
the
assess/issue311-macos-capture
branch
from
November 20, 2026 14:37
2c98198 to
efccac8
Compare
houko
force-pushed
the
assess/issue311-macos-capture
branch
from
November 20, 2026 15:15
efccac8 to
30b5e87
Compare
Collaborator
Author
|
Reviewed.
|
houko
force-pushed
the
assess/issue311-macos-capture
branch
from
November 20, 2026 16:06
30b5e87 to
3b9d9f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
macOS test captures now convert both WindowServer composites and AppKit fallback bitmaps to sRGB before PNG encoding. This keeps pixel comparisons reproducible on Display P3 machines while preserving the composited path for Core Animation shadows, masks, filters, animations, backdrops, and caret rendering. The capture regression fixture comment and English and Chinese testing docs now describe the conversion.
Checks:
go tool nsgo check -target macos -jobs 1go tool nsgo test -target macos -run '^TestMountIgnoresCommandsForMissingViews$' ./internal/platform/macosgo tool nsgo test -target macos ./internal/testhost/testdata/capture(the composited capture case cannot pass in this environment because WindowServer returned no image and the documented AppKit fallback was used)