Repository navigation
Conversation
houko
force-pushed
the
assess/issue772-select-native
branch
2 times, most recently
from
November 20, 2026 15:02
5b1518d to
f6071f6
Compare
houko
force-pushed
the
assess/issue772-select-native
branch
from
November 20, 2026 15:21
f6071f6 to
97908c8
Compare
houko
force-pushed
the
assess/issue772-select-native
branch
from
November 20, 2026 16:06
97908c8 to
eb935e6
Compare
houko
force-pushed
the
assess/issue772-select-native
branch
from
November 20, 2026 16:42
eb935e6 to
f7f7634
Compare
houko
force-pushed
the
assess/issue772-select-native
branch
from
November 20, 2026 17:34
71492ca to
7594b95
Compare
App.Select moves a GTK field's selection with Select All, Left and Shift+Right keys sent back to back. Under X11 a selection the first Shift+Right had just extended was sometimes collapsed again by display events GTK handled only after the next key had been sent, so the range came out one character short and TestSelectMovesTheNativeSelection failed about one run in three on Xvfb. The test host now syncs with the display server after each key and lets the loop turn once, as a user's next key always comes after those events.
houko
force-pushed
the
assess/issue772-select-native
branch
from
November 20, 2026 18:18
7594b95 to
31f9782
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.Selectthrough native editing keys so the platform field receives the requested rangeCloses #772
Verification
go tool nsgo test ./nsgotestgo tool nsgo check -target macos,linux,windows,web -jobs 2