Skip to content

fix(nsgotest): apply Select through native fields - #1015

Open
houko wants to merge 2 commits into
mainfrom
assess/issue772-select-native
Open

houko wants to merge 2 commits into
mainfrom
assess/issue772-select-native

Conversation

@houko

@houko houko commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • route target App.Select through native editing keys so the platform field receives the requested range
  • preserve the existing headless selection model and avoid synthetic target selection events
  • add a target regression test that replaces a selected range by typing

Closes #772

Verification

  • go tool nsgo test ./nsgotest
  • go tool nsgo check -target macos,linux,windows,web -jobs 2

@github-actions github-actions Bot added bug Something isn't working size/S documentation Improvements or additions to documentation labels Nov 20, 2026
@houko
houko force-pushed the assess/issue772-select-native branch 2 times, most recently from 5b1518d to f6071f6 Compare November 20, 2026 15:02
@github-actions github-actions Bot added the macOS label Nov 20, 2026
@houko
houko force-pushed the assess/issue772-select-native branch from f6071f6 to 97908c8 Compare November 20, 2026 15:21
@github-actions github-actions Bot added size/M Linux cli size/S conflict Conflicts with the base branch; resolve it first and removed size/S size/M labels Nov 20, 2026
@houko
houko force-pushed the assess/issue772-select-native branch from 97908c8 to eb935e6 Compare November 20, 2026 16:06
@github-actions github-actions Bot added size/M conflict Conflicts with the base branch; resolve it first and removed conflict Conflicts with the base branch; resolve it first size/S labels Nov 20, 2026
@houko
houko force-pushed the assess/issue772-select-native branch from eb935e6 to f7f7634 Compare November 20, 2026 16:42
@github-actions github-actions Bot added conflict Conflicts with the base branch; resolve it first and removed conflict Conflicts with the base branch; resolve it first labels Nov 20, 2026
@houko
houko force-pushed the assess/issue772-select-native branch from 71492ca to 7594b95 Compare November 20, 2026 17:34
@github-actions github-actions Bot added conflict Conflicts with the base branch; resolve it first and removed conflict Conflicts with the base branch; resolve it first labels Nov 20, 2026
App.Select moves a GTK field's selection with Select All, Left and Shift+Right keys sent back to back. Under X11 a selection the first Shift+Right had just extended was sometimes collapsed again by display events GTK handled only after the next key had been sent, so the range came out one character short and TestSelectMovesTheNativeSelection failed about one run in three on Xvfb. The test host now syncs with the display server after each key and lets the loop turn once, as a user's next key always comes after those events.
@houko
houko force-pushed the assess/issue772-select-native branch from 7594b95 to 31f9782 Compare November 20, 2026 18:18
@github-actions github-actions Bot removed the conflict Conflicts with the base branch; resolve it first label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli documentation Improvements or additions to documentation Linux macOS size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nsgotest -target: Select moves only the model selection, not the native field's

1 participant