ZSTD support - #34
Open
jschueller wants to merge 2 commits into
Open
Conversation
jschueller
force-pushed
the
zstd
branch
2 times, most recently
from
August 15, 2026 19:27
f071d68 to
56e62fb
Compare
sredna
reviewed
Aug 15, 2026
jschueller
force-pushed
the
zstd
branch
3 times, most recently
from
August 15, 2026 21:07
6d44cca to
2dbdabc
Compare
jschueller
marked this pull request as ready for review
August 15, 2026 21:08
Author
|
Thank you for updating my PR! I'm not part of the NSIS team though, so I can't really help you get this merged. I see you've updated zstd - I had made a few patches to reduce the size of exehead: https://github.com/dbeinder/nsis/blob/d353438eff9244cc2416e1b7bb0b17551a25941d/Source/zstd/zstd-v1.5.6.diff Not sure if this is still worth doing, or if the NSIS team considers minimal exehead size a priority. |
Author
|
I think its best not to alter the zstd sources for easier maintenance, or changes must be upstreamed first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refreshed #28 without the math changes, and no asm, as requested
also forwarded the new data size argument to zstd
/cc @dbeinder @sredna