Skip to content

ZSTD support - #34

Open
jschueller wants to merge 2 commits into
nsis-dev:masterfrom
jschueller:zstd
Open

ZSTD support#34
jschueller wants to merge 2 commits into
nsis-dev:masterfrom
jschueller:zstd

Conversation

@jschueller

@jschueller jschueller commented Aug 15, 2026

Copy link
Copy Markdown

refreshed #28 without the math changes, and no asm, as requested
also forwarded the new data size argument to zstd

/cc @dbeinder @sredna

@jschueller
jschueller force-pushed the zstd branch 2 times, most recently from f071d68 to 56e62fb Compare August 15, 2026 19:27
Comment thread Contrib/zip2exe/Base.nsh Outdated
@jschueller
jschueller force-pushed the zstd branch 3 times, most recently from 6d44cca to 2dbdabc Compare August 15, 2026 21:07
@jschueller
jschueller marked this pull request as ready for review August 15, 2026 21:08
@jschueller

Copy link
Copy Markdown
Author

hello @sredna, would it be possible to approve the workflow to at least run the CI ?
ping @dbeinder

@dbeinder

dbeinder commented Aug 29, 2026

Copy link
Copy Markdown

Thank you for updating my PR! I'm not part of the NSIS team though, so I can't really help you get this merged.

I see you've updated zstd - I had made a few patches to reduce the size of exehead: https://github.com/dbeinder/nsis/blob/d353438eff9244cc2416e1b7bb0b17551a25941d/Source/zstd/zstd-v1.5.6.diff
It basically strips out unused code for unpacking with the help of a separate dictionary file and the built-in XXH64 checksum which should be redundant.

Not sure if this is still worth doing, or if the NSIS team considers minimal exehead size a priority.

@jschueller

Copy link
Copy Markdown
Author

I think its best not to alter the zstd sources for easier maintenance, or changes must be upstreamed first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants