Conversation
This reverts commit 8825f65. Reverted for sequencing only -- the fix itself is correct and verified. It changes generated output, and the v1.1.1 plan lands all output-neutral fixes first so they can be checked against a single unchanged baseline. To re-apply after the remaining output-neutral fixes land: git cherry-pick 8825f65 The change is one line in src/nsl/Constant.java: the constructor took a realName parameter and assigned `this.realName = null`, discarding it. $NSISDIR is the only one of 41 registered constants with a non-null realName (ConstantList.java:36), so it emitted as `$NSISDIR` rather than `${NSISDIR}`. NSIS does not error on that -- it warns 6000 "unknown variable/constant, ignoring" and silently drops the value. Verified before reverting: fixes all warnings on a $NSISDIR fixture, including the interpolated `"${NSISDIR}\Contrib"` case, and leaves all 13 examples byte-identical (none of them reference $NSISDIR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.