item: More methods and members - #7
Merged
Merged
Conversation
Luminyx1
requested changes
Aug 13, 2026
Luminyx1
left a comment
Luminyx1
left a comment
Member
There was a problem hiding this comment.
Noted some changes, a few things are minor nitpicks but most should be fixed
| ItemBase(const ActorCreateParam& param); | ||
| virtual ~ItemBase(); | ||
|
|
||
| bool draw()override; |
Member
There was a problem hiding this comment.
all of these are missing a space before override
| { | ||
| SEAD_RTTI_OVERRIDE(ItemBase, ActorMultiState) | ||
| protected: | ||
| enum ItemTypes |
| return *mStateMgr.getOldStateID() == state_id; | ||
| } | ||
|
|
||
| const StateID* getCurrentState() |
| return DirType(param_0 >> 24 & 0xF); | ||
| } | ||
|
|
||
| PlayerMode getModePrev() |
Member
There was a problem hiding this comment.
both of these new getters should be marked const
|
|
||
| DirType getDirection() | ||
| { | ||
| return _2a00; |
Member
There was a problem hiding this comment.
is _2a00 known to be actually mDirection? if so that should be renamed too
Luminyx1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.