-
Notifications
You must be signed in to change notification settings - Fork 2
[rntuple] Read a column's value range as IEEE 754 doubles #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sathabbott
merged 2 commits into
nsmith-:main
from
sathabbott:fix/75-column-range-doubles
Sep 30, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| from skhep_testdata import data_path # type: ignore[import-not-found] | ||
|
|
||
| from rootfilespec.bootstrap import ROOT3a3aRNTuple | ||
| from rootfilespec.reader import open_path | ||
| from rootfilespec.rntuple.RNTuple import RNTuple | ||
| from rootfilespec.rntuple.schema import ColumnType | ||
|
|
||
|
|
||
| def test_column_value_range_is_double(): | ||
| """Issue #75: a column's value range is a pair of IEEE 754 doubles | ||
|
|
||
| The file's quantized columns (4 to 10, fields quant1 to quant32) all have | ||
| the range [-2.0, 3.0]. Read as int64, the same bytes are the bit patterns | ||
| -4611686018427387904 and 4613937818241073152. | ||
| """ | ||
| filename = "test_float_types_rntuple_v1-0-0-0.root" | ||
| with open_path(data_path(filename)) as reader: | ||
| anchor = reader.fetch(reader.keylist()["ntuple"]) | ||
| assert isinstance(anchor, ROOT3a3aRNTuple) | ||
| rntuple = RNTuple.from_anchor(anchor, reader.fetch.buffer) | ||
|
nsmith- marked this conversation as resolved.
|
||
|
|
||
| columns = rntuple.schemaDescription.columnDescriptions | ||
| with_range = [i for i, c in enumerate(columns) if c.fFlags & 0x02] | ||
| assert with_range == list(range(4, 11)) | ||
| for i in with_range: | ||
| column = columns[i] | ||
| assert column.fColumnType == ColumnType.kReal32Quant | ||
| assert column.fMinValue == -2.0 | ||
| assert column.fMaxValue == 3.0 | ||
| assert isinstance(column.fMinValue, float) | ||
| for i, column in enumerate(columns): | ||
| if i not in with_range: | ||
| assert column.fMinValue is None | ||
| assert column.fMaxValue is None | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.