Repository navigation
Skip test_compressed_size.py without the root-io-spec submodule - #136
Merged
nsmith- merged 1 commit intoOct 1, 2026
Merged
Conversation
It reads root-io-spec's container/compress-*.root fixtures but, unlike the other modules that use them, had no skip, so its 4 cases failed in a checkout without the submodule. Follow-up to nsmith-#130, which added it. Assisted-by: claude-code:claude-opus-5-5
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 92.51% 92.51%
=======================================
Files 37 37
Lines 2994 2994
=======================================
Hits 2770 2770
Misses 224 224 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@nsmith- this is a very straightforward PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #130.
tests/test_compressed_size.pyreads root-io-spec'scontainer/compress-{zlib,lzma,lz4,zstd}.rootfixtures, but unlike the other modules that use the submodule it had no skip, so in a checkout withoutreference/root-io-specits 4 cases failed instead of skipping. It now has the samepytestmark = pytest.mark.skipif(not DATA.exists(), ...)astest_page_checksums.py.Tests: without the submodule (the test suite run from a copy that has no
reference/),maingives 4 failures, all in this module; with this change,260 passed, 12 skipped, 22 xfailed. With the submodule, the full suite is unchanged:471 passed, 61 skipped, 50 xfailed. The same check on the open PRs' branches (#127, #129, #131, #132) finds no other module with the problem.Found while checking
AGENTS.md(#134), which now says a test that uses the fixtures must skip without them.Assisted-by: claude-code:claude-opus-5-5