Skip to content

Skip test_compressed_size.py without the root-io-spec submodule - #136

Merged
nsmith- merged 1 commit into
nsmith-:mainfrom
sathabbott:test/skip-compressed-size-without-submodule
Oct 1, 2026
Merged

nsmith- merged 1 commit into
nsmith-:mainfrom
sathabbott:test/skip-compressed-size-without-submodule

Conversation

@sathabbott

Copy link
Copy Markdown
Collaborator

🤖 AI generated content

Follow-up to #130. tests/test_compressed_size.py reads root-io-spec's container/compress-{zlib,lzma,lz4,zstd}.root fixtures, but unlike the other modules that use the submodule it had no skip, so in a checkout without reference/root-io-spec its 4 cases failed instead of skipping. It now has the same pytestmark = pytest.mark.skipif(not DATA.exists(), ...) as test_page_checksums.py.

Tests: without the submodule (the test suite run from a copy that has no reference/), main gives 4 failures, all in this module; with this change, 260 passed, 12 skipped, 22 xfailed. With the submodule, the full suite is unchanged: 471 passed, 61 skipped, 50 xfailed. The same check on the open PRs' branches (#127, #129, #131, #132) finds no other module with the problem.

Found while checking AGENTS.md (#134), which now says a test that uses the fixtures must skip without them.

Assisted-by: claude-code:claude-opus-5-5

It reads root-io-spec's container/compress-*.root fixtures but, unlike
the other modules that use them, had no skip, so its 4 cases failed in a
checkout without the submodule. Follow-up to nsmith-#130, which added it.

Assisted-by: claude-code:claude-opus-5-5
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (79fd46d) to head (d1042f0).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files          37       37           
  Lines        2994     2994           
=======================================
  Hits         2770     2770           
  Misses        224      224           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sathabbott
sathabbott requested a review from nsmith- October 1, 2026 01:20
@sathabbott

Copy link
Copy Markdown
Collaborator Author

@nsmith- this is a very straightforward PR

@nsmith-
nsmith- merged commit bd99cee into nsmith-:main Oct 1, 2026
9 checks passed
@sathabbott
sathabbott deleted the test/skip-compressed-size-without-submodule branch October 1, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants