fix: allow abbreviation on sorted mismatch maps - #241
felipeofdev-ai wants to merge 1 commit into
Conversation
with-ellision-marker assoc'd EllisionMarker into the mismatch map. Sorted maps require Comparable keys, which caused ClassCastException when *use-abbreviation* abbreviated a PersistentTreeMap. Convert sorted maps to hash-maps before inserting ellision markers. Fixes nubank#234 Signed-off-by: Felipe Fernandes <felipe.of.dev@gmail.com>
|
Friendly bump: CI shows Nu workflow processing errors on — Felipe Fernandes · https://github.com/felipeofdev-ai |
|
Hi @felipeofdev-ai, I'm a co-maintainer here but haven't worked at Nubank for over 5 years. I have a personal policy were I don't review work done mainly by LLM-tools (elaborated slightly here). You might have luck with someone at Nubank who takes interest in the changes suggested here and in the 5 other pull requests you opened yesterday. That said, it has been a few years since anyone inside of Nubank has offered code reviews on pull requests here. If you are indeed coming across these issues with the library and want to see them resolved, feel free to open an issue and we can talk over the trade-offs of how to go about resolving them, or I'm happy to offer support if you want to try to get familiar with the library and do it yourself (in such a case, I would ask you not to use LLM-tools while we collaborate). And of course, if you open a pull request with code that isn't largely written using LLM tools, I'm happy to review those. |
Summary
EllisionMarkerkeys during abbreviation.ClassCastExceptiononPersistentTreeMap.Why
with-ellision-markerusedassocwith a non-Comparablemarker key. Sorted mismatch maps require comparable keys, which surfaces asClassCastExceptionwhen*use-abbreviation*is enabled (issue #234).Fixes #234
Test plan
matcher-combinators.printer-test/with-ellision-marker-sorted-map— Felipe Fernandes · Systems & Agentic AI Engineer
https://github.com/felipeofdev-ai · https://felipeofdev-ai.github.io/