Repository navigation
Try an optional fishing celebration on Angler catches - #53
Closed
nulllogicone wants to merge 1 commit into
Closed
nulllogicone wants to merge 1 commit into
nulllogicone wants to merge 1 commit into
Conversation
2 of 4 tasks
Owner
Author
|
Nice idea but too much noise in code for little gimmik |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angler results currently offer no playful feedback when a PostIt matches. This experiment adds an opt-in, finite fishing animation, a browser-saved preference, and a replay button. It respects reduced-motion preferences and leaves the existing SQL matchmaking and message data unchanged.
Try the shared partial with a fixed sample catch at
/experiments/fishing-celebration, also linked from/design-overview. Real Angler pages show it when results exist; enabled celebrations run on page visits for matches not yet celebrated in that tab.Tracks #52; original idea #47. Keep this PR in draft until the owner reviews the online preview and decides whether to revise, merge, or discard it.
Validation: Release build passed; all 11
PostItCreationTestspassed; JavaScript syntax and diff checks passed. Browser checks covered opt-in, replay, disabling, preference persistence, and no repeat feedback after reloading the same sample. Reduced-motion and responsive rules were inspected but not emulated; hosted Angler data has not yet been exercised. Existing dependency/compiler warnings remain.Expected preview after the push deployment succeeds: https://oliitrazorweb-test.azurewebsites.net/experiments/fishing-celebration
The preview slot is shared. Deployment evidence and the deployed commit will be recorded on #52. Durable behavior and validation notes: experiment documentation.