Skip to content

fix(notify): scope run/jobs lookups to github.repository with optional run-token - #22

Closed
gamechanger1s wants to merge 4 commits into
mainfrom
feat/notify-run-token
Closed

gamechanger1s wants to merge 4 commits into
mainfrom
feat/notify-run-token

Conversation

@gamechanger1s

@gamechanger1s gamechanger1s commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Bug

The Slack card is missing DURATION and FAILED AT when the caller sets target-repo for cross-org attribution.

notify@v4.0.0 calls the Actions API on target-repo to fill those two rows — but Actions runs only exist in github.repository. So the calls 404, get swallowed by 2>/dev/null, and both rows silently disappear.

Same-repo callers (target-repo == github.repository) never saw it.

Fix

  • Look up run/jobs on github.repository (that's where the run actually is — hard-coded, not overridable).
  • Add optional run-token for those two calls; falls back to github-token, so existing callers are byte-identical.
  • Also fixes a load-time crash from ${{ }} inside the composite action's description: block.

Fully additive — no consumer has to change to keep working.

@gamechanger1s
gamechanger1s deleted the feat/notify-run-token branch August 11, 2026 14:13
@gamechanger1s gamechanger1s changed the title feat(notify): scope run/jobs lookups to github.repository with optional run-token fix(notify): scope run/jobs lookups to github.repository with optional run-token Aug 11, 2026
@gamechanger1s

Copy link
Copy Markdown
Contributor Author

Superseded by #23 — same branch (renamed feat/notify-run-token → fix/notify-run-token, fix: is the correct commit type). GitHub auto-closed this PR during the branch rename and does not allow reopen once the head ref is orphaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant