Conversation
Introduce SchemaSyncTool, sync script, and documentation to keep ACP constants and schema types aligned with upstream schema sources. Co-authored-by: Cursor <cursoragent@cursor.com>
Rebuild constants and schema model types from stable and unstable upstream definitions, including union/object translations and updated unstable type placement. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace handwritten RequestId usage with the generated schema variant, update endpoint validity checks, and adjust the sandbox sample to the current tool-call payload shape. Co-authored-by: Cursor <cursoragent@cursor.com>
BrettKulp
added a commit
to BrettKulp/acp-csharp
that referenced
this pull request
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a schema-driven sync workflow for ACP C# models and applies a full regeneration from upstream schema sources.
What changed
SchemaSyncToolto sync:meta.json/meta.unstable.jsonschema.json/schema.unstable.jsontools/SchemaSyncTool/README.mddocs/schema-sync-plan.mdscripts/sync-schema.ps1src/AgentClientProtocol/Schema(including unstable models).RequestIdimplementation and aligned JSON-RPC runtime usage to generated schema type.sandbox/ConsoleApp1/Program.csfor current payload handling.Design principles
formatmappings are respected during generation (int32,int64,uint16,uint32,uint64).RequestIdnow follows schema-driven generation path.Validation
dotnet build src/AgentClientProtocol/AgentClientProtocol.csprojdotnet run --project tools/SchemaSyncTool -- checkBoth passed successfully.