fix(docs): preserve query and hash in version redirects - #2415
fix(docs): preserve query and hash in version redirects#2415rahimahisah17 wants to merge 1 commit into
Conversation
|
@rahimahisah17 is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe documentation version middleware now redirects with a route object. The object adds the documentation version to the path and preserves the query parameters and hash. The redirect remains a 302 response. Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to Documentation version redirects now retain query parameters and hash fragments while adding the current version path. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Production bundleComparing
Largest module increases
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Linked Issue
Closes #2060
Description
This change updates the documentation version redirect middleware to preserve the URL query parameters and hash fragment when redirecting to the current documentation version.
Previously, the redirect rebuilt the URL from to.fullPath, which could result in the URL hash being lost during the redirect.
The redirect now passes path, query, and hash explicitly to navigateTo().
Testing
pnpm exec playwright test test/browser/pages.spec.ts --timeout=60000git diff --checkpasses