Repository navigation
Conversation
timweri
force-pushed
the
fix/allowed-signer-parse
branch
3 times, most recently
from
November 10, 2026 03:38
620b4a9 to
8fb127f
Compare
Replace AllowedSignerSplitter with a parser that follows OpenSSH's parse_principals_key_and_options() and sshsigopt_parse() in sshsig.c. Options are one comma-separated field with double-quoted values, as OpenSSH requires. Space-separated options and unquoted values, which OpenSSH rejects, are now rejected too. Like OpenSSH 10.2, option names and the timestamp suffix (Z or UTC) are case-insensitive, valid-after and valid-before must be after the epoch, and any text after the key is a comment. BREAKING CHANGE: lines with space-separated options or unquoted values no longer parse, including lines written by the old Display. AllowedSignerParsingError::UnexpectedEnd and InvalidTimestamp are removed.
timweri
force-pushed
the
fix/allowed-signer-parse
branch
from
November 11, 2026 18:15
8fb127f to
93b9123
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flagged by Opus 5.5.
AllowedSigner::from_stringaccepted linesssh-keygenrejects, such as space-separated options and unquoted values, and rejected lines it accepts, such as text after the key without#. It now followsparse_principals_key_and_options()andsshsigopt_parse()in sshsig.c, checked againstssh-keygen -Y verify10.2.Like OpenSSH, option names and the
Z/UTCsuffix are case-insensitive, andvalid-after/valid-beforemust be after the epoch.Displaystill writes the old format but #55 will that.BREAKING CHANGE: lines with space-separated options or unquoted values no longer parse, including lines written by the old
Display.AllowedSignerParsingError::UnexpectedEndandInvalidTimestampare removed.