Repository navigation
Workspace UI: paginate session directory (#183) and preserve composer drafts (#185) - #199
Conversation
Fetch all session pages (bounded, stale-guarded) for the conversation recipient/filter dropdowns and channel author names, disambiguating duplicate display names while keeping offline labels. Stale directory pages arriving after a workspace switch are discarded. Keep unsent conversation and channel/thread drafts in memory, scoped to account, workspace and destination. Drafts survive tab navigation and refreshes, retain their idempotency key across failed sends, and clear only after a confirmed send. Sign-out forgets that account's drafts. Fixes #183, Fixes #185.
🤖 Agentbox PR audit: changes requestedWhat needs to change The two features work and CI is green. Six edge cases in the new code need closing before merge. Everything is in
To test: in What this PR changes
Full audit (Claude (fable, xhigh) × Codex (gpt-6-astra, xhigh), 4 turns, commit 2157862)PR audit: #199 — Workspace UI: paginate session directory (#183) and preserve composer drafts (#185)Head: 2157862 Sign-off
Decisioncomment — six edge cases in the new draft, recipient, label and paging code need closing; each fix is small, but together with their tests they exceed what we should apply blind on the branch. What changes (plain language)
FindingsBlocking
Non-blocking
Fix plann/a Message to the developerThe two features work and CI is green. Six edge cases in the new code need closing before merge. Everything is in
To test: in Questions for Harshn/a Verification
Audit log
Automated review by Harsh's agentbox: two AI reviewers audited this PR against the project ruleset and agreed on it. |
… paging (#199) Per-view draft keys computed before the first await; detached-composer upload guard; key-matched draft clear on send; explicit-choice recipient release plus unavailable-recipient placeholder; collision-proof session labels; uncapped directory paging with no-progress stop. Seven new Playwright regression tests; bundle rebuilt with web's own build.
|
Pushed 32bc542 addressing the round-1 audit (all six blockers plus the seven tests and rebuild):
Local gates on the exact head: Playwright 28/28 pass, |
🤖 Agentbox PR audit: changes requestedWhat needs to change We tried to apply these fixes ourselves but stopped: Committed fix-plan steps 1-3 as ec44ee3 (web/src/app.js:418 guard no longer requires a non-empty saved recipient; both test extensions added exactly as planned). Step 4 is NOT done: bus/hostedweb/app.js was not regenerated, because web/ has no node_modules and this step forbids installing dependencies and running builds, and the plan forbids hand-editing the bundle. The committed bundle is now stale against the source and still ships the old guard until someone runs Please apply the fix plan. n/a What this PR changes
Full audit (Claude (fable, xhigh) × Codex (gpt-6-astra, xhigh), 2 turns, commit 32bc542)PR audit: #199 — Workspace UI: paginate session directory (#183) and preserve composer drafts (#185)Head: 32bc542 Sign-off
Decisionfix — one condition in the new recipient guard lets a draft with text fall back to another session after an edit; it is a one-line change plus a test extension and a bundle rebuild. What changes (plain language)
FindingsBlocking
Non-blocking
Fix plan
Message to the developerWe tried to apply these fixes ourselves but stopped: Committed fix-plan steps 1-3 as ec44ee3 (web/src/app.js:418 guard no longer requires a non-empty saved recipient; both test extensions added exactly as planned). Step 4 is NOT done: bus/hostedweb/app.js was not regenerated, because web/ has no node_modules and this step forbids installing dependencies and running builds, and the plan forbids hand-editing the bundle. The committed bundle is now stale against the source and still ships the old guard until someone runs Please apply the fix plan. n/a Questions for Harshn/a Verification
Audit log
Automated review by Harsh's agentbox: two AI reviewers audited this PR against the project ruleset and agreed on it. |
…dits (#199) The recipient guard no longer requires a non-empty saved recipient, so a draft edited while the placeholder is selected keeps the unavailable state across rebuilds instead of falling back to another session. Extends the vanished-session test with the edit-navigate-reselect transition and hardens the late-upload test; regenerates bus/hostedweb/app.js with web's own build.
|
Pushed fbc8aac applying the round-2 fix plan (all four steps):
Local: full web suite 28/28 green. CI run 43496161220: all 11 checks green incl. workspace-ui (bundle-freshness gate + playwright). |
🤖 Agentbox PR audit: ready to mergeWhat this PR changes
Full audit (Claude (claude-opus-5-5, xhigh) × Codex (gpt-6.1-sol, xhigh), 2 turns, commit fbc8aac)PR audit: #199 — Workspace UI: paginate session directory (#183) and preserve composer drafts (#185)Head: fbc8aac Sign-off
Decisionmerge — no blocking findings; the round-2 fix plan is applied in full, the bundle matches the source, and all 11 checks pass on this head. What changes (plain language)
FindingsBlockingNone. Non-blocking
Fix plann/a Message to the developern/a Questions for Harshn/a Verification
Audit log
Final checks (run once, after both agents agreed)web: npm ci --ignore-scripts — PASS; 0 vulnerabilities Automated review by Harsh's agentbox: two AI reviewers audited this PR against the project ruleset and agreed on it. |
Batch A (workspace-UI intermediate JS).
Fixes #183, Fixes #185.
#183 — sessions after the first 100 selectable
messagesView()recipient/filter dropdowns and the channel author-name directory now follow the existingafter/nextCursorsession pages (bounded at 50 pages, de-duplicated by id) instead of using only the first page.· offlinesuffixes retained.#185 — draft preservation
Tests
web/tests/workspace.spec.js: 101-session two-page directory with duplicate names + delayed-stale workspace switch; draft survival across tabs/refresh/workspace-switch with attachment URI and no-storage assertion; failed-send key reuse; independent channel/thread drafts; cross-account isolation via sign-out/sign-in.npx playwright test: 19/19 pass. Bundle regenerated withnpm run build.