Repository navigation
Workspace UI: keep burst messages reachable during live refresh - #200
harshsaver wants to merge 3 commits into
Conversation
Poll the newest history page, then walk back over burst pages (bounded to three) until they overlap what is already on screen. When the walk ends without overlapping, leave an explicit gap control that loads the missed range in place, so bursts larger than one page and hidden-tab resumes no longer strand messages between pages. Applies to conversations and channels; stale results are discarded on navigation and composer contents are untouched. Regenerate the embedded browser bundle.
|
Merged origin/main into this branch (6cd558c) to resolve the conflict with #192. web/src/app.js auto-merged; web/tests/workspace.spec.js kept both appended blocks (burst tests + dialog a11y tests); the generated bus/hostedweb/app.js bundle was rebuilt with web's own build (npm run build) rather than hand-edited. Spec + src syntax-checked, Go build passes locally; CI re-running. |
…load Insert rows loaded by the gap control before the control itself, so it always sits directly above the older block instead of staying above the rows it just loaded. Applies to conversations and channels. Add a 400-item regression for each view that checks the control's neighbours after a partial load and the full row order once the gap closes. Regenerate the embedded browser bundle with web's build. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🤖 Agentbox PR audit: small fixes applied, then ready to mergeWhat this PR changes
Full audit (Claude (fable, xhigh) × Codex (gpt-6-astra, xhigh), 2 turns, commit efb4dff)PR audit: #200 — Workspace UI: keep burst messages reachable during live refreshHead: 6cd558c Sign-off
Decisionfix — the design is sound, but the gap button stays above the rows it loads; the existing two-line fix and regression test resolve the blocking UX defect. What changes (plain language)
FindingsBlocking
Non-blocking
Fix plan
Nothing else changes. The non-blocking items are left for a follow-up. Message to the developern/a Questions for Harshn/a Verification
Audit log
Fixes applied by the audit
Final checks (run once, after both agents agreed)npm ci --ignore-scripts — PASS; 0 vulnerabilities. Automated review by Harsh's agentbox: two AI reviewers audited this PR against the project ruleset and agreed on it. |
|
Verified the audit fix at head |
Fixes #184.
Each 5s refresh used to prepend only the newest page, so a burst larger than one page stranded the middle: unreachable without a full reload, with no history control created. Conversations and channels now share one live-refresh pattern:
beforecursor until they overlap what is on screen.Tests: 5 new Playwright regressions in the existing mocked harness (110-message auto catch-up, 200-message gap control + fill, hidden-tab resume for conversations, 200-post channel burst with older history already loaded, hidden-tab resume for channels). Full browser suite 19/19 green locally;
go build ./..." andgo test ./bus/green. Embedded bundle regenerated (npm run build); CI drift check coversbus/hostedweb`.