Open the sector axis on the wire - #75
Closed
LKSNDRTMLKV wants to merge 1 commit into
Closed
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 277 |
| Duplication | 15 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
LKSNDRTMLKV
force-pushed
the
refactor/crate-boundaries
branch
from
July 30, 2026 14:47
9309099 to
c795ae9
Compare
LKSNDRTMLKV
force-pushed
the
feat/open-sector-lane
branch
from
July 30, 2026 14:47
a3005e6 to
6f97d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #74 — review that first; this diff is only the sector-lane commit.
Brings the open sector lane forward from 0.14.0 into 0.13.0, so there is one breaking release and one engine repin rather than two.
The defect
The catalog, schema registry, per-field disclosure map and plugin manifests are all string-keyed data.
SectorandSectorDatawere plain derives — the latter internally tagged onsector— so:SectorData::Othermatched only the literal tag"other", so even the fallback discarded the real key;The sector model was open in the catalog and closed at the front door. Adding packaging cost a core release, an engine repin and a CI matrix change.
The change
Sector::Other(String)andSectorData::Other { sector, data }now carry the tag, with hand-writtenSerialize/Deserializethat fall through instead of failing. The shape on the wire is unchanged — still an internally-tagged object withsectoras the discriminant. Only the unknown-tag behaviour differs.An unknown sector round-trips byte-identically, which is the property that matters: a signature is computed over those bytes, so anything less would break verification for a passport this build cannot type.
validate_sector_data_with_registrynow resolves a validator by the sector's own key rather than by a literal"other"— the key is preserved precisely so dispatch can be by name.Merge gate
crates/dpp-tests/tests/open_sector_lane.rs, 8 tests:sector()reports the real key, not a placeholderunsold-goods,unsoldGoods) resolve to the typed variantFull
just checkgreen: fmt, clippy, workspace tests, doctests, all ten plugins, docs with-D warnings, audit.Deliberately not included
ADR-010 pairs this with deleting typed lanes for provisional sectors. Eight of eleven catalog sectors are provisional — including textile, which has 7 engine references, a full E2E test, its own plugin, and is the pilot sector. That is a capability decision needing an explicit call, and unlike the wire format it is not clamped to first issuance: deleting code stays free, changing the wire does not. Shipping this alone captures the whole deadline benefit.
Port signatures still take
&Sectorrather than a bare key. They now work for unknown sectors because the key travels insideSector::Other, so that remaining change is ergonomic, not blocking.Downstream
The engine repin (odal-node/dpp-engine#66) predates this and does not yet cover it.
Sectoris no longerCopyandSector::Otheris no longer a unit variant, so that PR needs a follow-up commit before 0.13.0 publishes.