docs(types): source the retention floor to the acts that state it - #61
Merged
Conversation
ESPR sets no retention figure - Art. 9(2)(i) ties availability to expected product lifetime - so attributing 3650 days to it was wrong; the 10 years comes from the toy, detergent and CPR operator duties, and the comment now records the two cases the constant deliberately does not express.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MIN_RETENTION_DAYS = 3650was documented as an "ESPR-driven minimum data-retention floor". ESPR states no retention figure at all.Verified against the OJ text (
dpp-docs/reference/legal/OJ_L_202401781_EN_TXT.pdf): Art. 9(2)(i) requires availability for "at least the expected lifetime of a specific product" — product-specific, delegated per product group, and no such delegated act has been adopted.The 10 years is real, but it comes from the regulations that do state a figure: Reg. (EU) 2025/2509 (toys) and (EU) 2026/405 (detergents) both require 10 years after placing on the market "including in cases of insolvency, liquidation or cessation of activity", and Reg. (EU) 2024/3110 (CPR) imposes the same 10 years on the economic operator.
Comment-only change. The constant is unchanged and correct.
Two things the comment now records
retentionYearsvalue. Tracked indpp-infra#2anddpp-control-plane#1.retentionYears: 10with no legal basis. Tracked indpp-core#65.Note
I initially reported that construction was under-retaining by 15 years. That was wrong — I collapsed CPR's operator and system duties on first read. The manifests are correct; the provenance was not.