Skip to content

Add 0% GST tax code and component to default tax config - #3799

Merged
vigneshhari merged 2 commits into
developfrom
claude/add-0-percent-gst-code
Oct 18, 2026
Merged

vigneshhari merged 2 commits into
developfrom
claude/add-0-percent-gst-code

Conversation

@Claude

@Claude Claude AI commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

  • config/settings/config.py
    • TAX_CODES default: added the gst code (display: "GST", system http://ohc.network/codes/monetary/tax).
    • TAX_MONETARY_COMPONENT_DEFINITIONS default: added GST @ 0 with factor: 0, next to the existing 18%, 12% and 5% slabs.
  • .env.example: updated the comments for both settings to list GST and the 0% slab.
{
    "title": "GST @ 0",
    "code": {"code": "gst", "display": "GST", "system": "http://ohc.network/codes/monetary/tax"},
    "monetary_component_type": "tax",
    "factor": 0,
}

factor: 0 is accepted. The MonetaryComponent validators check factor is not None, not truthiness, so a 0 factor doesn't fail the "amount or factor required" check.

Only the defaults change. Deployments that set TAX_CODES or TAX_MONETARY_COMPONENT_DEFINITIONS through env vars must add the new entries themselves.

Associated Issue

  • Adds a 0% GST option to the default tax component config, as the issue requests. Exempt or nil-rated items can now carry an explicit 0% tax component instead of having none.

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@Claude Claude AI assigned Claude and bodhish Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 67d14b66-067d-4b4f-b9fc-2bf4eaaacaff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Claude Claude AI linked an issue Oct 18, 2026 that may be closed by this pull request
@Claude Claude AI changed the title [WIP] Add 0% GST to default configuration for tax components Add 0% GST tax code and component to default tax config Oct 18, 2026
@Claude
Claude AI requested a review from bodhish October 18, 2026 19:09
@vigneshhari
vigneshhari marked this pull request as ready for review October 18, 2026 19:22
@vigneshhari
vigneshhari requested a review from a team as a code owner October 18, 2026 19:22
Copilot AI balanced review requested due to automatic review settings October 18, 2026 19:22
@vigneshhari
vigneshhari merged commit 2bae933 into develop Oct 18, 2026
9 checks passed
@vigneshhari
vigneshhari deleted the claude/add-0-percent-gst-code branch October 18, 2026 19:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped default additions match the request and existing zero-factor handling, with no unresolved findings.

No open issues 🎉

What changed in this PR

Adds an explicit 0% GST option to CARE’s default tax configuration, addressing #3798.

Changes:

  • Adds the GST tax code and a GST @ 0 component with factor 0.
  • Updates environment-example comments; existing environment overrides remain unchanged.
File Description
config/​settings/​config.py Adds GST and its 0% tax component to defaults.
.env.example Updates comments to include GST and the 0% slab.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 0% GST as a new code for tax components

4 participants