Repository navigation
Add 0% GST tax code and component to default tax config - #3799
Merged
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Agent-Logs-Url: https://github.com/ohcnetwork/care/sessions/20bb1e64-6155-4893-afe5-390e6dc0f74d Co-authored-by: bodhish <14979190+bodhish@users.noreply.github.com>
vigneshhari
marked this pull request as ready for review
October 18, 2026 19:22
There was a problem hiding this comment.
🟢 Approval recommended
The scoped default additions match the request and existing zero-factor handling, with no unresolved findings.
No open issues 🎉
What changed in this PR
Adds an explicit 0% GST option to CARE’s default tax configuration, addressing #3798.
Changes:
- Adds the GST tax code and a
GST @ 0component with factor0. - Updates environment-example comments; existing environment overrides remain unchanged.
| File | Description |
|---|---|
config/settings/config.py |
Adds GST and its 0% tax component to defaults. |
.env.example |
Updates comments to include GST and the 0% slab. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
config/settings/config.pyTAX_CODESdefault: added thegstcode (display: "GST", systemhttp://ohc.network/codes/monetary/tax).TAX_MONETARY_COMPONENT_DEFINITIONSdefault: addedGST @ 0withfactor: 0, next to the existing 18%, 12% and 5% slabs..env.example: updated the comments for both settings to list GST and the 0% slab.{ "title": "GST @ 0", "code": {"code": "gst", "display": "GST", "system": "http://ohc.network/codes/monetary/tax"}, "monetary_component_type": "tax", "factor": 0, }factor: 0is accepted. TheMonetaryComponentvalidators checkfactor is not None, not truthiness, so a 0 factor doesn't fail the "amount or factor required" check.Only the defaults change. Deployments that set
TAX_CODESorTAX_MONETARY_COMPONENT_DEFINITIONSthrough env vars must add the new entries themselves.Associated Issue
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins