Repository navigation
Restrict permissions on stored credentials file - #65
Merged
Merged
Conversation
The config file holding the API token was written with the default mode (0644 under a typical umask) inside a 0755 directory, so other local users could read the token when the home directory is not private. Create ~/.ohdear with 0700 and set config.json to 0600 before writing, which also tightens files written by earlier versions on next write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nelwhix
marked this pull request as ready for review
October 21, 2026 21:05
Contributor
|
Thanks! |
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CredentialStorewrote~/.ohdear/config.json(which holds the API token in plain JSON) without setting a file mode, so it ended up0644inside a0755directory. On systems where the home directory isn't private, other local users could read the token.0700instead of0755config.jsonto0600before writing the contents, so the token is never in a world-readable file, and write withLOCK_EX0644files from earlier versions get tightened the next time the CLI writes them (login/logout)Existing
~/.ohdeardirectories aren't re-chmodded. The file itself is protected, and the path can be overridden withOHDEAR_CONFIG_FILE_PATH, so changing the permissions of a directory we didn't create seemed wrong.Tests
0600and the new directory is07000644file is tightened to0600onsetTokenflush()leaves the file at0600Permission tests are skipped on Windows.
composer test,composer analyseand Pint all pass.