Preserve async tile loading state - #63
Open
janstehno wants to merge 1 commit into
Open
Conversation
Fixes flickering during map movement when tiles are loaded asynchronously. This change adds a ValueKey to each tile widget based on its zoom level and tile coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a stable
ValueKeyto each tile widget based on its zoom level and tile coordinates.Without a key, Flutter could recreate tile widgets when the tile stack changed during map movement. This caused async tile loading state to be lost and resulted in visible tile flickering.
By preserving tile widget identity, ongoing async loading is maintained across rebuilds.