Repository navigation
aurora-sep: count boot.bin device trees with bash 5.2 too - #161
Closed
chriskearney wants to merge 1 commit into
Closed
chriskearney wants to merge 1 commit into
chriskearney wants to merge 1 commit into
Conversation
m3_report_boot_dt() finds the device trees in m1n1's boot.bin by their magic with grep -ob, and read each "offset:match" line. The match is the magic's bytes, which are not valid UTF-8, and bash 5.2's read returns nothing for such a line in a UTF-8 locale: the report then says "device trees in boot.bin: 0" on any system with bash 5.2 (Ubuntu 24.04, for one), and the M3 report tests fail there. Arch's bash 5.3 reads the lines, which is why the tests pass on Omarchy. Keep only the offsets before read sees them. Signed-off-by: Chris Kearney <303316+iconidentify@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chriskearney
added a commit
that referenced
this pull request
Oct 20, 2026
Collaborator
Author
|
Folded into #160 as its own commit (same change), so the fixes and the CI that found them land together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m3_report_boot_dt()(the M3 report ininstall-aurora-sep.sh) counts the device trees in m1n1'sboot.binby finding their magic withgrep -ob. It then reads eachoffset:matchline withread. The match is the magic's raw bytes (d0 0d fe ed), which aren't valid UTF-8, and bash 5.2'sreadreturns nothing for such a line in a UTF-8 locale. On any system with bash 5.2, the report saysdevice trees in boot.bin: 0. Arch's bash 5.3 reads the lines, so this never showed on Omarchy, but the M3 report tests intools/aurora-sep/tests/test_m3_max.pyfail on Ubuntu 24.04. #160's host-test job is where this showed up.The fix keeps only the offsets (
| cut -d: -f1) beforereadsees them.Tested
test_m3_max.py -k ReportTestfails 5 cases without the change (run) and passes all 7 with it (run).test_m3_max.pystill pass.🤖 Generated with Claude Code