Describe the dispatch-driven release flow in releasing.md - #718
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba1b83ee3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…language check passes; user-visible runbook)
…repository_dispatch runs from main, so the v*-tag-only policy blocked the publish job; validator, policy, tests, and runbook now match)
ba1b83e to
9a4d1fb
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a4d1fbca9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-merge window before dispatch (doc-language passes; SR-29 runbook accuracy)
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
docs/releasing.md sections 9-10 and one Principles bullet still described the release trigger as a tag push (
git push origin refs/tags/$VERSION, "the tag-triggeredReleaseworkflow"). That has been stale since.github/workflows/release.ymlmoved toon: repository_dispatchonly. This updates those sections to describe the actual flow: pushing the signed tag does not start anything; arepository_dispatchevent of typereleasedoes, GitHub always loads the workflow from the default branch (never the tag), and the workflow's tag-policy gate re-verifies the pushed tag (annotated, GitHub-verified signature, targets the payload commit) before anything else runs. It also documentsTAG_SIGNED_RELEASESinscripts/verify-release-artifact.sh: only the closed set of releases published before this change (v1.0.2) verify against the pushed-tag signing identity; every later release verifies only against the default-branch identity. No other stale tag-push-trigger language remains in the file (checked with grep).Prose was written to pass
scripts/check-doc-language.shagainst the existingpolicy/doc-language-baseline.tsvbaseline with no new rows added; the checker exits 0 on this branch.Second deliverable, not a file change: this PR also documents that the live
releaseGitHub environment was audited against the hosted-controls validator (internal/metadatautil/hostedcontrols.go) and found already compliant, so no live change was needed.gh api repos/omkhar/workcell/environments/releaseshowscan_admins_bypass=falseanddeployment_branch_policy={protected_branches:false, custom_branch_policies:true}, andgh api repos/omkhar/workcell/environments/release/deployment-branch-policiesshows exactly one policy,{"name":"v*","type":"tag"}, with no branch-type policies — matchingpolicy/github-hosted-controls.toml's[workflow_environment.release](deployment_tags = ["v*"],allow_admin_bypass = false) exactly. The full live cross-check,scripts/verify-github-hosted-controls.sh omkhar/workcell, exits 0 against the live repo.