Quote the textconv fixture path in the session-commands scenario - #725
Merged
Conversation
… a hostile TMPDIR (git runs textconv via sh; the tmpdir axis path has a space and backtick; mirrors the filter fix in #724)
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tmpdir hostile-environment axis roots the scenario workspace under a TMPDIR that contains a space, a literal $HOME, and a backtick command substitution. PR #724 fixed the git external clean filter for this axis but left the sibling diff textconv fixture with the same defect, so the tmpdir axis still failed on shared/session-commands.
Git runs a textconv command through a shell. The scenario registered diff.workcell.textconv with an unquoted absolute path and wrote textconv.sh with a double-quoted marker path. Under the hostile TMPDIR the shell word-splits the path and runs the backtick as a command, so the textconv invocation fails.
This quotes both sites, mirroring the filter fix in #724: the textconv.sh marker touch now uses single quotes, and the diff.workcell.textconv value stores a single-quoted path. Scenario intent is unchanged.
Verified: bash -n and shellcheck clean. The full scenario runs only in the container tmpdir axis; the other three axes already pass.