Repository navigation
Float the background-work chip and open it as a card - #113
Merged
Merged
Conversation
The background-work chip sat in an opaque band above the composer because the transcript spacer reserved the whole dock, chip included. Only the rest of the dock now reserves space, measured in one piece, and the inverted list pads its newest end by the chip's height. The transcript scrolls under the chip, and touches beside it reach the rows behind. The chip spins while a subagent runs, shows a still terminal glyph when only shells run, and keeps the warm dot when something needs you. Tapping it opens a card over the chip instead of a sheet: the screen dims, tapping outside closes it, and a shell's page opens inside the card. The card is measured from the chip again on rotation, resize, keyboard changes and once shown, and stays within the safe area. Choosing an agent, model or variant no longer folds the composer. A hold keeps it expanded until the prompt is tapped and blurs, or the prompt is sent, so focus passing through the prompt as a sheet closes does not fold it. Model changes read inline as "Model changed to" the model and variant.
The shell page inside the background-work card kept the sheet's 360pt output cap, so the output stayed small in a tall card. In the card the output now grows into the space the page leaves. Choosing a variant opened a full-screen sheet for a handful of options. It now opens as a card just above the Variant button, headed with the model name. The card gains an "above" placement for this. A session-screen test now chooses an agent through the real dock and checks that the composer stays expanded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iPhone screenshots showed four problems around the composer: the background-work chip sat in an opaque band, the composer folded after an agent choice, model changes hid behind a disclosure, and the chip's spinner competed with the Working line.
pointerEvents="box-none"through the dock). iOS scroll indicators are inset to match.WorkingIndicator) while a subagent runs. When only shells run it shows a still terminal glyph, info-colored when confirmed and dim when last known. The warm dot stays for needs-you. The label is unchanged ("1 subagent · 1 shell").PopoverCardover the chip, with the screen dimmed behind. Tapping outside closes it. Sections are unchanged: Needs you, Subagents, Shells, and finished subagents. A shell's page opens inside the card. Android back and the iOS escape gesture step back from the shell page to the list.onDismisson iOS, and throughuseReturnFocusAfterClose, now exported frommodal-sheet.tsx, on Android.model·variant" like the agent change, with nothing to expand. Screen readers hear a comma instead of "·".Revisions were published as EAS Updates to
preview(runtime 0.1.6). The latest revision is published from this branch's commit09c0290(update groupc89981dd). Every changed file is JavaScript.Known limits:
measureInWindowalignment with the status-bar-translucent card needs device evidence.Verification
pnpm check(1575 mobile tests, adapter tests, both Hermes exports)pnpm native:doctor(18/18)pnpm crap --threshold 30box-nonethrough the dock, the chip icon per kind,Keyboard.dismisson chip press, the card's bottom pin, height clamp,fill, re-measuring on resize,keyboardDidHideand show, asymmetric safe-area insets, escape stepping back, backdrop close and reopen, the composer hold (agent and variant choice, focus without a tap, tap then blur, cancel, send), and the inline model change with its spoken label.docs/COMPATIBILITY.md.TODO.mdreflect the resulting behavior.Council review
Rounds: 6
Rounds 1 to 3 reviewed the floating chip and the first composer fix. Round 2 scored the composer separately (Opus 8, GPT Sol 9, Gemini 8), and the table shows the chip scores. Rounds 4 to 6 reviewed the revised composer fix, the inline model change, the chip icon and the card. Gemini's round 4 note that the composer could fold mid-tap was fixed in round 5. Opus's round 6 note about a late measurement leaving a stale position for one frame was left as is, because the effect measures again on open.