Skip to content

Spec says name is required for Link Objects, but example does not have it set #648

Description

@Simon-Laux

this is basically the same thing as #647.

The example does not follow the spec. In the spec the name field is required.
spec: https://spec.open-rpc.org/#link-object
example: link-example-openrpc.json

"links": {
      "UserRepositories": {
        "description": "Get the repositories by owner.",
        "summary": "Get the repos by owner",
        "server":{
          "name": "Other Server Name",
          "description": "Use other server instead",
          "url": "http://localhost:9210"
        },
        "method": "get_repositories_by_owner",
        "params": {
          "username": "${result.username}"
        }
      },
      "UserRepository": {
        "method": "getRepository",
        "params": {
          "username": "${result.owner.username}",
          "slug": "${result.slug}"
        }
      },
      "RepositoryPullRequests": {
        "method": "getPullRequestsByRepository",
        "params": {
          "username": "${result.owner.username}",
          "slug": "${result.slug}"
        }
      },
      "PullRequestMerge": {
        "method": "mergePullRequest",
        "params": {
          "username": "${result.author.username}",
          "slug": "${result.repository.slug}",
          "pid": "${result.id}"
        }
      }
    },

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions