Skip to content

Fix timeout always defaulting to 5000ms #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrleblanc101 wants to merge 4 commits into from
Closed

Fix timeout always defaulting to 5000ms #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a215202
Fix timeout
mrleblanc101 Mar 26, 2025
0215c31
Fix private timeout type
mrleblanc101 Mar 26, 2025
410cde6
Handle initial value of undefined
mrleblanc101 Mar 26, 2025
6e1b01a
Allow undefined
mrleblanc101 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class <%= className %> {
| PostMessageWindowTransport
| PostMessageIframeTransport;
private validator: MethodCallValidator | undefined;
private timeout: number | undefined;
private timeout: number | null | undefined;

constructor(options: Options) {
if (
Expand Down Expand Up @@ -131,9 +131,9 @@ export class <%= className %> {
* // 20s timeout
* myClient.setDefaultTimeout(20000);
* // Removes timeout from request
* myClient.setDefaultTimeout(undefined);
* myClient.setDefaultTimeout(null);
*/
public setDefaultTimeout(ms?: number) {
public setDefaultTimeout(ms?: number | null) {
this.timeout = ms;
}

Expand Down
6 changes: 3 additions & 3 deletions src/custom-test-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class <%= className %> {
public static openrpcDocument: OpenRPC = <%= JSON.stringify(openrpcDocument) %> ;
public transport: HTTPTransport | WebSocketTransport | PostMessageWindowTransport | PostMessageIframeTransport;
private validator: MethodCallValidator;
private timeout: number | undefined;
private timeout: number | null | undefined;

constructor(options: Options) {

Expand Down Expand Up @@ -86,9 +86,9 @@ export class <%= className %> {
* // 20s timeout
* myClient.setDefaultTimeout(20000);
* // Removes timeout from request
* myClient.setDefaultTimeout(undefined);
* myClient.setDefaultTimeout(null);
*/
public setDefaultTimeout(ms?: number) {
public setDefaultTimeout(ms?: number | null) {
this.timeout = ms;
}

Expand Down