Skip to content

Py adbc fixes - #286

Merged
m-kuhn merged 2 commits into
open-vcpkg:mainfrom
couteau:py-adbc-fixes
Oct 20, 2026
Merged

m-kuhn merged 2 commits into
open-vcpkg:mainfrom
couteau:py-adbc-fixes

Conversation

@couteau

@couteau couteau commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

This PR adds a port for the importlib-resources package from PyPi and updates the py-adbc-driver-manager to 1) depend on the new py-importlib-resources package and 2) to depend on the arrow dataset feature. Both of these are needed for full functionality for ADBC.

The upcoming version of ADBC (currently on RC2) will eliminate the importlib-resources dependency and replace it with the standard library importlib.resources module, but that will also involve an upgrade to the arrow and pyarrow packages, which may take some time to make their way into a qgis release/vcpkg baseline update.

If adding a short-lived dependency for a soon-to-be-obsolete package is not desired, other options aside from adding the new package and dependency would be 1) to wait for the new version of ADBC, or 2) patch the current ADBC to use the standard library instead of a third-party package. Given QGIS's now requiring python 3.12 and the importlib.resources API being stable since 3.11, patching should not create compatibility issues.

However the importlib-resources dependency is handled, the arrow dataset dependency is needed to enable adbc/pandas interoperability.

@m-kuhn m-kuhn closed this Oct 18, 2026
@m-kuhn m-kuhn reopened this Oct 18, 2026
@m-kuhn

m-kuhn commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Thanks for improving things here, adding this as a proper solution is fine IMHO even if short lived.

@m-kuhn
m-kuhn merged commit c8c6cb3 into open-vcpkg:main Oct 20, 2026
7 of 10 checks passed
@couteau
couteau deleted the py-adbc-fixes branch October 20, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants