Repository navigation
Py adbc fixes - #286
Merged
Merged
Py adbc fixes#286
Conversation
Contributor
|
Thanks for improving things here, adding this as a proper solution is fine IMHO even if short lived. |
m-kuhn
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a port for the
importlib-resourcespackage from PyPi and updates thepy-adbc-driver-managerto 1) depend on the newpy-importlib-resourcespackage and 2) to depend on the arrowdatasetfeature. Both of these are needed for full functionality for ADBC.The upcoming version of ADBC (currently on RC2) will eliminate the
importlib-resourcesdependency and replace it with the standard libraryimportlib.resourcesmodule, but that will also involve an upgrade to thearrowandpyarrowpackages, which may take some time to make their way into a qgis release/vcpkg baseline update.If adding a short-lived dependency for a soon-to-be-obsolete package is not desired, other options aside from adding the new package and dependency would be 1) to wait for the new version of ADBC, or 2) patch the current ADBC to use the standard library instead of a third-party package. Given QGIS's now requiring python 3.12 and the
importlib.resourcesAPI being stable since 3.11, patching should not create compatibility issues.However the
importlib-resourcesdependency is handled, the arrowdatasetdependency is needed to enable adbc/pandas interoperability.