fix(cli): preserve analytics settings in finding workflows - #801
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2909d137d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Validation uses parsed TOML, but forwarding re-filters the raw --codex string by prefix. Valid inputs like analytics.enabled = false or analytics = { enabled = false } pass validation but are dropped here, leaving the native runtime unchanged. Please forward the normalized parsed analytics.enabled value and add a spaced/inline-table regression.
Summary
validate,patch, andverify-fixcurrently reject--codex 'analytics.enabled=false', so disabling Codex analytics for a scan does not cover standalone follow-up commands. Accept this setting through their existing--codexoption and carry the scan's explicit analytics setting into automatic patching.Changes
analytics.enabledto the native Codex runtime for finding validation, patching, fix verification, and patch risk assessment.trueorfalsewhenscan --patchstarts its patch workflow.Testing
pnpm run typesandpnpm run format: passed.pnpm run test --seed 12345: 2,307 passed, 41 skipped, 0 failed.pnpm run test(random seed949832507): 2,307 passed, 41 skipped, 0 failed.Risk and rollout
This extends the accepted keys of the existing
--codexoption onvalidate,patch, andverify-fix; it adds no flags and changes no telemetry defaults. Existing model and reasoning-effort overrides, configuration isolation, and patch project-trust behavior are preserved.analytics.enabled=falsedisables Codex analytics and metrics; model requests, authentication, enabled integrations, explicitly configured OpenTelemetry log or trace exporters, and the CLI update check remain separate.Public disclosure review