Update pyo3 to 0.29 - #152
Open
gordonmessmer wants to merge 1 commit into
Open
Conversation
pyo3 0.26 removed `PyObject` from the prelude and, together with the `IntoPyObject` conversion rework, made `Ok(py_obj.into())` on a `PyResult<PyObject>` return type ambiguous (multiple applicable `wrap` impls). Return the `Bound<'py, PyAny>` produced by `call_method1` directly instead, which is unambiguous and works across recent pyo3 releases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyo3 0.26 removed
PyObjectfrom the prelude and, together with theIntoPyObjectconversion rework, madeOk(py_obj.into())on aPyResult<PyObject>return type ambiguous (multiple applicablewrapimpls). Return theBound<'py, PyAny>produced bycall_method1directly instead, which is unambiguous and works across recent pyo3 releases.