chore(api): document stored chat completion errors - #1086
Conversation
Castiron-Internal-PR: openai/openai-java-internal#156 Castiron-Source-SHA: de07cea132c62ec2b4ae1cc4445e81912c7a20fd Castiron-Public-Base-SHA: 840bb12
Castiron custom code✅ No new custom-code files detected. 92 mixed files remain; 0 existing customizations changed. Compared 92 existing customizations unchanged
52 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36173624925 --repo openai/openai-java \
--name castiron-custom-code-36173624925-1 --dir /tmp/castiron-custom-code-36173624925-1
git apply --stat /tmp/castiron-custom-code-36173624925-1/custom-code.patch
cat /tmp/castiron-custom-code-36173624925-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 840bb120c0d37313aa494ef2bd3a6981a2089341 83f83bbd05a9cb3a1a2dac1868149012822793a3
python3 scripts/castiron/custom_code_report.py report \
--base 840bb120c0d37313aa494ef2bd3a6981a2089341 \
--head 83f83bbd05a9cb3a1a2dac1868149012822793a3 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-83f83bbd05a9
cat /tmp/castiron-custom-code-83f83bbd05a9/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed 83f83bbd05a9cb3a1a2dac1868149012822793a3 — no actionable findings.
Independently parsed and compared the complete base/head OpenAPI artifacts: exactly 17 documented error responses are added across the five stored Chat Completion operations; all other semantic content is unchanged. Every new schema/response reference resolves, and the transformed-spec checksum matches .castiron.stats.yml. The full two-file diff leaves Java/Kotlin APIs, exception types, runtime code, dependencies, and workflows unchanged.
All reported exact-head repository CI checks are green, including API/Jackson compatibility and Java 8/25 runtime tests. The separately reported downstream compatibility run is not included in that statement and remains to be verified. I did not rerun Gradle or make live API calls locally for this documentation-only change.
|
Thanks for the independent review. The approved head is unchanged: only the API reference and generation metadata differ from main, with all Java/Kotlin APIs, exception handling and runtime code preserved. PR checks pass. The separate downstream compatibility run has now also passed all 236 cases. |
Summary
Documents errors for stored chat completions while preserving Java method signatures and exception types.
Changes