Skip to content

chore(api): document fine-tuning and model errors - #1087

Merged
dpiet-oai merged 1 commit into
mainfrom
castiron/promotions/pr-157
Sep 25, 2026
Merged

dpiet-oai merged 1 commit into
mainfrom
castiron/promotions/pr-157

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies fine-tuning and model error responses while retaining existing Java behavior.

Changes

  • Describe applicable validation, lookup, permission and rate-limit errors.
  • Preserve existing method signatures, exception types and runtime behavior.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

92 mixed files remain; 0 existing customizations changed.

Compared 6b226243eac2 → 0f12b904565a. Generated baselines verified.

92 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/audio/transcriptions/TranscriptionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ImageServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/SkillServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/VideoServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranslationServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/chat/ChatCompletionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/finetuning/checkpoints/PermissionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/skills/VersionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaService.kt

52 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 36183596342 --repo openai/openai-java \
  --name castiron-custom-code-36183596342-1 --dir /tmp/castiron-custom-code-36183596342-1
git apply --stat /tmp/castiron-custom-code-36183596342-1/custom-code.patch
cat /tmp/castiron-custom-code-36183596342-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 6b226243eac24cd295dd26fcc18cf45f19358b54 0f12b904565af350457b4e7ebe97e807e753ec12
python3 scripts/castiron/custom_code_report.py report \
  --base 6b226243eac24cd295dd26fcc18cf45f19358b54 \
  --head 0f12b904565af350457b4e7ebe97e807e753ec12 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-0f12b904565a
cat /tmp/castiron-custom-code-0f12b904565a/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

Castiron-Internal-PR: openai/openai-java-internal#157
Castiron-Source-SHA: c927021f50c1756a7774019d0a307fd55e78878a
Castiron-Public-Base-SHA: 6b22624
@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-157 branch from be297cf to 0f12b90 Compare September 25, 2026 20:03
@markstuart-oai
markstuart-oai marked this pull request as ready for review September 25, 2026 20:04
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 25, 2026 20:04
@openai-sdks

openai-sdks Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 15.748s for Java SDK PR #1087.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 172ms
tests/chat-completions-create.test.ts ✅ Passed 525ms
tests/chat-completions-stream.test.ts ✅ Passed 333ms
tests/files-content-binary.test.ts ✅ Passed 271ms
tests/files-create-multipart.test.ts ✅ Passed 279ms
tests/files-list-pagination.test.ts ✅ Passed 267ms
tests/initialize-config.test.ts ✅ Passed 214ms
tests/instance-isolation.test.ts ✅ Passed 190ms
tests/models-list.test.ts ✅ Passed 212ms
tests/responses-background-lifecycle.test.ts ✅ Passed 212ms
tests/responses-body-method-errors.test.ts ✅ Passed 503ms
tests/responses-cancel-timeout.test.ts ✅ Passed 220ms
tests/responses-cancel.test.ts ✅ Passed 250ms
tests/responses-compact-retries.test.ts ✅ Passed 270ms
tests/responses-compact.test.ts ✅ Passed 213ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 432ms
tests/responses-create-advanced.test.ts ✅ Passed 1.293s
tests/responses-create-disconnect.test.ts ✅ Passed 971ms
tests/responses-create-errors.test.ts ✅ Passed 323ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 165ms
tests/responses-create-retries.test.ts ✅ Passed 232ms
tests/responses-create-stream-failures.test.ts ✅ Passed 165ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 255ms
tests/responses-create-stream-wire.test.ts ✅ Passed 6.103s
tests/responses-create-stream.test.ts ✅ Passed 518ms
tests/responses-create-terminal-states.test.ts ✅ Passed 344ms
tests/responses-create-timeout.test.ts ✅ Passed 208ms
tests/responses-create.test.ts ✅ Passed 1.198s
tests/responses-delete.test.ts ✅ Passed 242ms
tests/responses-input-items-errors.test.ts ✅ Passed 252ms
tests/responses-input-items-list.test.ts ✅ Passed 257ms
tests/responses-input-items-options.test.ts ✅ Passed 167ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 232ms
tests/responses-input-tokens-count.test.ts ✅ Passed 295ms
tests/responses-malformed-inputs.test.ts ✅ Passed 5.304s
tests/responses-not-found-errors.test.ts ✅ Passed 384ms
tests/responses-parse.test.ts ✅ Passed 648ms
tests/responses-retrieve-retries.test.ts ✅ Passed 283ms
tests/responses-retrieve.test.ts ✅ Passed 196ms
tests/responses-stored-method-errors.test.ts ✅ Passed 1.161s
tests/retry-behavior.test.ts ✅ Passed 3.426s
tests/sdk-error-shape.test.ts ✅ Passed 411ms

View OkTest run #36183563557

SDK merge (456d4290681c) · head (0f12b904565a) · base (6b226243eac2) · OkTest (f9111d4e2fcd)

Copy link
Copy Markdown
Contributor Author

Thanks @dpiet-oai for reviewing. The final candidate keeps existing Java APIs, exception types and runtime behavior unchanged; the API/Jackson compatibility checks and all 236 downstream cases pass.

@dpiet-oai
dpiet-oai added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 2bfb718 Sep 25, 2026
16 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants