Show registration modal only when unregistered by gregorydlogan · Pull Request #1600 · opencast/admin-interface

gregorydlogan · 2026-05-04T05:28:34Z

This PR only shows the registraiton modal when the adopter has not already registered.

~~This PR contains a few extra bits that haven't been turned on yet - notably the warning bell stuff for when the core can't reach the registration server.~~

This PR now uses the bell if the user is not registered. Notably:
If you haven't registered at all:

If you have registered, but haven't agreed to the latest ToU:

Clicking on either of these notices opens the registration modal.

Requires opencast/opencast#7786 on the backend.

TODOs:

~~Make the new strings into translatable strings rather than hardcoding them.~~
~~In the case of an out of date ToU, uncheck the agreed-to-ToU checkbox when presenting the registration modal, and highlight what's wrong.~~
In the case of an out of date ToU, launch the registration modal to the input pane, not the general info pane.

Fixed #1516

…tances

github-actions · 2026-05-04T05:29:37Z

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/admin-interface:pr-1600

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/admin-interface:pr-1600

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

github-actions · 2026-05-04T05:30:46Z

This pull request is deployed at test.admin-interface.opencast.org/1600/2026-05-11_21-10-31/ .
It might take a few minutes for it to become available.

…in suboptimal cases

gregorydlogan · 2026-07-13T19:46:05Z

Now that the GHA issues are done, I made a final change and I think this is ready for re-review @Arnei

Arnei · 2026-07-14T07:32:49Z

+            onClick={() => showAdoptersRegistrationModal()}
+          >
+            <span className="wide-text">Registration</span>
+            <span className="multi-value multi-value-yellow">Unregistered</span>


multi-value-yellow does not seem to exist (maybe I removed it in my cleaning frenzy?).

Arnei · 2026-07-14T07:34:04Z

+          <ButtonLikeAnchor
+            onClick={() => showAdoptersRegistrationModal()}
+          >
+            <span className="wide-text">Registration</span>


Untranslated strings.

The text in the little colored bubbles is now translated. Shouldn't "Registration" be translated too?

…represents whether the registration service can talk to the main registration server.

… the modal will open even if the user has already registered.

…ectors around to match

gregorydlogan · 2026-07-23T19:57:48Z

Ok, so I think this is more or less done...

I noticed that the registration modal itself was using a script in utils, so I removed it and moved its functionality into the selector. Hopefully I didn't miss anything obvious. This now requires opencast/opencast#7786 as well.

Arnei · 2026-07-27T07:52:42Z

+				// Refetch the registration data since otherwise what we just submitted does not show up if the user immediately returns to the modal
+				dispatch(fetchRegistration());


This seems like bad practice to me. We need to fetch registration data on modal open anyway, right? So if submitting closes the modal, and the user then reopens the modal, the data should be fetched anyway?

Unless we allow the user to submit without closing the modal, and the backend modifies the data we want to display?

I think this is an artifact of the registrationLoaded boolean, since it does not refetch without clearing that.

That fflag is there because the endpoint returns a bare null if there is no registration data, which makes differentiating between not-loaded and loaded-but-blank states hard. I hadn't started the backend pr changed when I added the loaded flags, so maybe I should change that in the backend pr...

Arnei · 2026-07-27T08:09:58Z

+		dateModified: "",
+		dateCreated: "",
 		registered: false,
+		statistics: null,


Why are we adding statistics to formik? I don't think we want to let the user change them? And it makes handling formik values more annoying, because now we have to do stuff like filter the statistics variable away (e.g. below in the summary)

Will swap this back!

Arnei · 2026-07-27T08:18:28Z

+	useEffect(() => {
+		if (!registrationLoaded) {
+			dispatch(fetchRegistration());
+		}
+		if (!statisticsLoaded) {
+			dispatch(fetchStatistics());
+		}
+	}, [registrationLoaded, statisticsLoaded, dispatch]);


Not quite sure on the logic here. When registration has loaded but statistics has not yet loaded, we want to fetch statistics again?

If you just want to fetch things once on component mount, you'd do

useEffect(() => { dispatch(fetchRegistration()); dispatch(fetchStatistics()); }, [dispatch]);

This is a bad rebase, I'll fix it. I was having issues with Formik and thought this was related.

Arnei · 2026-07-27T08:26:09Z

+
+
+  // post request for adopter information
+  export const postAdopterRegistration = async (


This block is one indentation level off

In theory this only opens the registration modal in the right circums…

48ae5a7

…tances

gregorydlogan added the type:bug Something isn't working label May 4, 2026

Arnei requested changes May 6, 2026

View reviewed changes

Comment thread src/components/Header.tsx Outdated

Comment thread src/components/Header.tsx Outdated

Comment thread src/slices/registrationSlice.ts

gregorydlogan added 5 commits May 7, 2026 15:46

Revert me for further work

c12f608

Removing summary, since it's not needed here

45f695b

Switching to useEffect, suggested in the review

92f70b3

Removing these since this part of the service does not care about this.

094d207

Modal now appears properly, and creates 'Registration' notifications …

298d1a8

…in suboptimal cases

gregorydlogan force-pushed the t/registration-modal branch from 75e3a11 to 298d1a8 Compare June 10, 2026 22:15

gregorydlogan added 2 commits July 13, 2026 11:16

Merge remote-tracking branch 'upstream/r/19.x' into t/registration-modal

6950c89

Combining useEffects

7bbefff

Arnei requested changes Jul 14, 2026

View reviewed changes

gregorydlogan added 9 commits July 15, 2026 10:32

Moving these dispatches out to prevent possible infinite loops

833d154

Fixing some tabs vs spaces

4720639

Adding translation strings to notifications

f22acfe

Replacing tabs with spaces

f1197ba

Renaming dumb type to something better

2d69560

Removing leftovers

8bfd332

Renaming isRegistering to something a little more sane. The variable …

e025708

…represents whether the registration service can talk to the main registration server.

These are not needed

20b62d1

Only opening the modal if the registration data has loaded, otherwise…

3247ac4

… the modal will open even if the user has already registered.

gregorydlogan force-pushed the t/registration-modal branch from 340024a to 3247ac4 Compare July 15, 2026 23:02

gregorydlogan added 2 commits July 23, 2026 12:04

Combining the last of the old utils script into the slice, moving sel…

ecace10

…ectors around to match

Harmonizing formatting to existing file structures

5a53c12

gregorydlogan mentioned this pull request Jul 23, 2026

Adopter registration backend fixes opencast/opencast#7786

Open

10 tasks

Arnei requested changes Jul 27, 2026

View reviewed changes

		// Refetch the registration data since otherwise what we just submitted does not show up if the user immediately returns to the modal
		dispatch(fetchRegistration());



		// post request for adopter information
		export const postAdopterRegistration = async (

Uh oh!

Conversation

gregorydlogan commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydlogan commented Jul 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Arnei Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydlogan commented Jul 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Arnei Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gregorydlogan commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

Arnei Jul 16, 2026 •

edited

Loading

Arnei Jul 27, 2026 •

edited

Loading