fix: default chat subscriptions to the outgoing session - #14
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: default chat subscriptions to the outgoing session This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-chat-session-keywas documented to mirror-session-key, but its hardcodedmaindefault prevented that fallback. A node sending transcripts to another session therefore subscribed to the wrong replies.Resolve an omitted or blank chat-session flag to the outgoing session while parsing configuration, preserve explicit overrides, and remove the obsolete runtime fallback. Help and README now agree with the implementation.
The regression table covers defaults, custom outgoing sessions, explicit
main, blank values and whitespace. It failed before the fix. A built binary against a synthetic loopback bridge subscribed tomainwith-session-key synthetic-sessionbefore; afterward it subscribed tosynthetic-session.Full race tests, vet, build, pinned deadcode and independent P0–P2 autoreview passed. No production gateway was used; Unreleased changelog updated.