Sort site language dropdown alphabetically - #1463
wakqasahmed wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @wakqasahmed! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 69.20% 69.22% +0.02%
==========================================
Files 119 119
Lines 2367 2369 +2
Branches 650 653 +3
==========================================
+ Hits 1638 1640 +2
Misses 684 684
Partials 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
The site language dropdown in Account Settings lists languages in whatever order
constants.jshappens to define them, which isn't alphabetical. This sortssiteLanguageOptionsSelector's output by the displayed language name (localeCompare) so the dropdown reads in a predictable order.Fixes #1338.
How Has This Been Tested?
Added
selectors.test.jsfor the site-language module, covering the sort order and confirming the selector doesn't mutate the underlyingsiteLanguageListarray. Ran the new file and the neighboringdata/selectors.test.jswithfedx-scripts jest, both green, and linted the changed files with no errors.Merge Checklist
Drafted with help from Claude (Anthropic); I reviewed the diff and tests and take responsibility for the change.