Skip to content

Sort site language dropdown alphabetically - #1463

Open
wakqasahmed wants to merge 1 commit into
openedx:masterfrom
wakqasahmed:fix/site-language-sort-order
Open

wakqasahmed wants to merge 1 commit into
openedx:masterfrom
wakqasahmed:fix/site-language-sort-order

Conversation

@wakqasahmed

Copy link
Copy Markdown

Description

The site language dropdown in Account Settings lists languages in whatever order constants.js happens to define them, which isn't alphabetical. This sorts siteLanguageOptionsSelector's output by the displayed language name (localeCompare) so the dropdown reads in a predictable order.

Fixes #1338.

How Has This Been Tested?

Added selectors.test.js for the site-language module, covering the sort order and confirming the selector doesn't mutate the underlying siteLanguageList array. Ran the new file and the neighboring data/selectors.test.js with fedx-scripts jest, both green, and linted the changed files with no errors.

Merge Checklist

  • Is there adequate test coverage for your changes?

Drafted with help from Claude (Anthropic); I reviewed the diff and tests and take responsibility for the change.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @wakqasahmed!

This repository is currently maintained by @jacobo-dominguez-wgu.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Sep 4, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Sep 9, 2026
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 9, 2026
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.22%. Comparing base (8f68cf3) to head (d5a01ad).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
+ Coverage   69.20%   69.22%   +0.02%     
==========================================
  Files         119      119              
  Lines        2367     2369       +2     
  Branches      650      653       +3     
==========================================
+ Hits         1638     1640       +2     
  Misses        684      684              
  Partials       45       45              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Tests Run or CLA Signed

Development

Successfully merging this pull request may close these issues.

Language selector should sort language output

3 participants