Conversation
(cherry picked from commit 5f1be33)
|
Thanks for the pull request, @RomkaSk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @RomkaSk! Welcome, and thank you for this contribution! In order for your CLA check to turn green, you'll need to submit a CLA form. If you are contributing as an individual, please fill out the individual CLA form here. If you are contributing on behalf of an organization, please have your manager reach out to oscm@axim.org so you may be added to your org's existing entity agreement. Please let me know if you have any questions. Thanks! |
|
@mphilbrick211 I've submitted the request to oscm@axim.org. |
|
@RomkaSk I believe we need to trigger the CI to the check on cla. |
|
@RomkaSk bumping the CLA request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 81.17% 81.22% +0.04%
==========================================
Files 51 51
Lines 834 836 +2
Branches 241 241
==========================================
+ Hits 677 679 +2
Misses 150 150
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Original PR to master: #1401
Description
Backport of #1401 to
release/verawood. Cleangit cherry-pick -xof the master commit;release/verawoodcarries the samesortedCountriesSelectorcode asmaster, so the diff is identical.On the learner profile page the Country selector renders with a single empty placeholder option — no countries can be selected. This happens on any deployment that keeps the platform default
REGISTRATION_EXTRA_FIELDS['country'] = 'hidden'.The profile builds its list of selectable countries from the registration form description (
GET /user_api/v1/account/registration/). That endpoint only includes acountryfield when the registration form is configured to show it. With the default'hidden',countriesCodesListarrives as[],sortedCountriesSelectorstill applies the allow-list filter, and every country is removed. Regression from #1185 (Verawood ships it).The fix ports the guard that
frontend-app-accountalready has inremoveDisabledCountries(): an empty allow-list means "the LMS does not restrict the choice", so the full localized list is returned. Where the LMS does send an allow-list, behaviour is unchanged. Embargoed countries are still rejected server-side on write, so this does not weaken the restriction. Full root-cause analysis and the Account Settings comparison are in #1401.How Has This Been Tested?
src/profile/data/selectors.test.jswith three cases forsortedCountriesSelector(empty allow-list returns the full list; non-empty list filters to exactly those codes; the country already saved on the account is kept). The first case fails onrelease/verawoodwithout this change.npm run lintclean,npm run testgreen on Node 24: 14 suites, 85 tests, 5 snapshots.REGISTRATION_EXTRA_FIELDS: the country<select>had 1 option; with this change it lists all countries.Merge Checklist
Post-merge Checklist
@openedx-release-manager please review as a Verawood backport.