Repository navigation
refactor: drop dead ENABLE_MFE_CONFIG_API override in development.py - #39139
Merged
Merged
Conversation
The ENABLE_MFE_CONFIG_API toggle was removed from the platform by the DEPR in #39019, which merged on 2026-08-26. The new development.py settings merged afterwards in #37444 on 2026-09-18, so this override was already dead when it landed. Nothing reads the setting now. MFEConfigView in lms/djangoapps/mfe_config_api/views.py serves /api/mfe_config/v1 with no toggle check, so assigning the name here has no effect. The comment above it is also wrong on its own terms: it says the API is off by default in common.py, and common.py no longer defines the flag at all. The comment asked for this cleanup once the DEPR landed, so this is that follow-up. DEPR: #38959 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
feanil
marked this pull request as ready for review
September 22, 2026 15:40
arbrandes
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup from #37444.
lms/envs/development.pysetENABLE_MFE_CONFIG_API = Trueso the dev MFEs could fetch their runtime config from the LMS. That toggle no longer exists. It was removed by the DEPR in #39019 on 2026-08-26, and #37444 merged afterwards on 2026-09-18, so the override was already dead when it landed.MFEConfigViewinlms/djangoapps/mfe_config_api/views.pyserves/api/mfe_config/v1with no toggle check, so the assignment has no effect. The comment above it is also wrong on its own terms: it says the API is off by default incommon.py, andcommon.pyno longer defines the flag at all. That comment asked for this removal once the DEPR landed, so this is that follow-up.No behavior change. The only remaining references to the flag are the three historical mentions in
lms/djangoapps/mfe_config_api/docs/decisions/0001-mfe-config-api.rst, which are intentional.Verified 2026-09-22 against platform master
bc38b6cbc1.