Skip to content

Adjusted the time exponent used in the heat storage energy constraint… - #717

Open
jldonner wants to merge 1 commit into
devfrom
697-bug-heat-storage-standing-loss-uses-fixed-exponent-1-p_loss124-wrong-for-non-hourly-timesteps
Open

Adjusted the time exponent used in the heat storage energy constraint…#717
jldonner wants to merge 1 commit into
devfrom
697-bug-heat-storage-standing-loss-uses-fixed-exponent-1-p_loss124-wrong-for-non-hourly-timesteps

Conversation

@jldonner

Copy link
Copy Markdown
Collaborator

… for inter-time-step state-of-charge coupling. Now fractions of hours can be simulated.

Description

The equation of the constraint_store_state() function no has the elapsed time now in the exponent making fractions of hours possible to propperly calculate.

Fixes #697

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

… for inter-time-step state-of-charge coupling. Now fractions of hours can be simulated.
@joda9
joda9 force-pushed the 697-bug-heat-storage-standing-loss-uses-fixed-exponent-1-p_loss124-wrong-for-non-hourly-timesteps branch from f3d9bfb to c476bb9 Compare August 4, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Heat-storage standing loss uses fixed exponent (1-p_loss)^(1/24) — wrong for non-hourly timesteps

1 participant