Preserve browser vhost hostname when proxying to openHAB - #626
Merged
digitaldan merged 2 commits intoAug 8, 2026
Merged
Conversation
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
There was a problem hiding this comment.
Pull request overview
Preserves the browser-facing virtual host when proxying requests to openHAB.
Changes:
- Sanitizes forwarded host headers and selects the browser proxy hostname.
- Adds browser-vhost integration coverage.
- Extends test configuration and web client host overrides.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/routes/index.ts |
Preserves the browser proxy host. |
tests/integration/socket/vhost-proxy.test.ts |
Tests host forwarding and sanitization. |
tests/integration/clients/web-client.ts |
Adds host override support. |
docker/config.test.json |
Configures the browser proxy test host. |
docker/config.ci.json |
Configures the browser proxy CI host. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+68
to
+72
| private applyHost<T extends supertest.Test>(req: T): T { | ||
| if (this.hostOverride) { | ||
| req.set('X-Forwarded-Host', this.hostOverride); | ||
| } | ||
| return req; |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.