8388142: [8u] Path to PreferredKey.java exclusion is wrong - #841
8388142: [8u] Path to PreferredKey.java exclusion is wrong#841adamfarley wants to merge 1 commit into
Conversation
Test was excluded due to issue that was later fixed. Also, the unexclusion refers to the old file location, which no longer exists, so the exclusion isn't excluding anything. Signed-off-by: Adam Farley <adfarley@ibm.com>
|
👋 Welcome back afarley! A progress list of the required criteria for merging this PR into |
|
@adamfarley This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/approval 8388142 request Request to unexclude a test because all issues it is linked to are resolved. Also, the test moved since it was excluded, and the exclusion no longer excludes anything. |
|
@adamfarley |
openjdk
Bot
added
the
approval
|
The only test failures I'm seeing are in CAInterop.java, which is not associated with this test as far as I can tell. |
|
As noted on the bug, only two of the four referenced issues are actually resolved. You seem to be misreading the bug being resolved as it being resolved everywhere, but you need to look at the fix version. If it is higher than the version concerned (in this case, 8) you need to look for backport issues to see if it has been backported to older versions. Or just use git log --grep= on a repository checkout. I think the main issue here is that the exclusion is redundant. The culprit for this is JDK-8245477 which moved the test nearly six years ago and never corrected the ProblemList.txt. As it has effectively been removed from the exclude list for all that time, I don't really see an issue with just removing it now. But the the test does exist and is currently failing, which should be resolved by #832 |
gnu-andrew
left a comment
gnu-andrew
left a comment
There was a problem hiding this comment.
Looks ok. Note that you should wait for a review before requesting approval.
|
/approve yes |
|
@gnu-andrew |
openjdk
Bot
removed
the
approval
|
The title of the PR needs to be changed to "8388142: [8u] Path to PreferredKey.java exclusion is wrong" |
adamfarley
changed the title
|
/integrate |
|
@adamfarley |
|
/sponsor |
|
Going to push as commit aa3f9de.
Your commit was automatically rebased without conflicts. |
openjdk
Bot
removed
ready
|
@gnu-andrew @adamfarley Pushed as commit aa3f9de. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
2 participants
Test was excluded due to issue that was later fixed.
Also, the unexclusion refers to the old file location, which no longer exists, so the exclusion isn't excluding anything.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/841/head:pull/841$ git checkout pull/841Update a local copy of the PR:
$ git checkout pull/841$ git pull https://git.openjdk.org/jdk8u-dev.git pull/841/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 841View PR using the GUI difftool:
$ git pr show -t 841Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/841.diff
Using Webrev
Link to Webrev Comment