Skip UseSetOf/UseListOf for HashSet/ArrayList subclasses - #1182
Merged
Conversation
`LinkedHashSet` matched the `new HashSet<>()` constructor matcher, so an ordered set built with `add(..)` statements was rewritten to `new HashSet<>(Set.of(..))`: uncompilable against the `LinkedHashSet` declared type, and dropping the iteration-order contract. Mirrors the `UseMapOf` guards added for #1113 and #1163.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new LinkedHashSet<>()matched thejava.util.HashSet <constructor>()matcher (which usesmatchOverrides, needed for the anonymous-subclass form), so:became
LinkedHashSet<TestObject> ordered = new HashSet<>(Set.of(t1, t2));— which doesn't compile, and would silently drop the iteration-order contract if it did.add(..)-chain form and the anonymous double-brace form now require the instantiated type to be exactlyjava.util.HashSet(resp.java.util.ArrayList), mirroring the guards already present inUseMapOffrom SkipUseMapOfforHashMapsubclasses likeLinkedHashMapandTreeMap#1113 and UseMapOf still convertsLinkedHashMaptoMap.offor the statement/put()form #1163.