fix: Don't go through the analyze measurement path for profile queries

[Swiddis]

Description

Don't go through the analyze measurement path for profile queries.

This means that "profile": true, "analyze": false queries are still paying the overhead for query analysis, which includes running the query twice among other things. In local measurement this causes ~800% performance regressions on frontend flows that use "profile": true assuming negligible overhead.

Run	Config	Avg (ms)	Overhead vs baseline
baseline	profile=false	30.17	—
reverted	profile=true	32.24	+2.07ms (6.9% slower)
current main	profile=true	272.66	+242.49ms (804% slower)

Related Issues

N/A

Check List

• New functionality includes testing.
• New functionality has been documented.
• New functionality has javadoc added.
• New functionality has a user manual doc added.
• New PPL command checklist all confirmed.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff or -s.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ahkcs]

Maybe we can hold this PR for now as the PR for analyze may be reverted soon cc @Krish-Gandhi @penghuo

[Swiddis]

Spoke with Krish, let's revert the one line first, if we need to revert the entire thing later we can just mix this delta in since it's trivial.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 6b67a00)

Here are some key observations to aid the review process:

🧪 PR contains tests

🔒 No security concerns identified

✅ No TODO sections

🔀 No multiple PR themes

⚡ Recommended focus areas for review Test Coverage Gap The test removes assertions for query, logicalPlan, physicalPlan, operator_tree, and recommendations fields without verifying they are absent or explaining why they should no longer be present. If these fields are no longer returned when profile=true and analyze=false, the test should explicitly assert their absence to document the behavioral change and prevent regressions. profile: true - gt: {profile.summary.total_time_ms: 0.0} - gt: {profile.phases.analyze.time_ms: 0.0} - gt: {profile.phases.optimize.time_ms: 0.0} - gt: {profile.phases.execute.time_ms: 0.0} - gte: {profile.phases.format.time_ms: 0.0} - gt: {profile.plan.time_ms: 0.0} - match: {profile.plan.rows: 2} - is_true: schema - is_true: datarows - match: {total: 2} - match: {size: 2}

[github-actions]

Persistent review updated to latest commit 6b67a00