OCPEDGE-3050: Add job exclusion file support to CI Doctor - #283
OCPEDGE-3050: Add job exclusion file support to CI Doctor#283redhat-chai-bot wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe PR adds per-plugin Prow job exclusion files and shared filtering for CI Doctor results. It adds eight LVMS exclusions, documents the MicroShift exclusion format, and bumps both plugin versions from patch releases. ChangesProw job exclusions
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to This change adds configurable per-plugin job exclusions and version updates, with no identified current merge-readiness risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 9 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (9 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (5 skipped: 5 unsupported.) Full details: Ai-AttributionExplanation AI use is explicit in the PR description and commit. The pull-request commit ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4de3c7c to
a8dfb2f
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
8ecba39 to
2659a33
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2659a33 to
998526c
Compare
| fi | ||
|
|
||
| local patterns | ||
| patterns=$(grep -vE '^[[:space:]]*(#|$)' "${EXCLUSION_FILE}" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//' || true) |
There was a problem hiding this comment.
Is second sed trying to remove spaces, etc around the tokens? If so, simple xargs call does that
Summary
Adds a file-based job exclusion mechanism to the CI Doctor's
prow-jobs-for-release.shscript, allowing each plugin (LVMS, MicroShift) to maintain its own list of disabled jobs to exclude from reports.Problem
When CI lanes are disabled in
openshift/release(e.g. PR #83972), Prow stops scheduling new runs butdata.jscontinues returning the last historical run. The CI Doctor report keeps showing these stale failures, inflating the failure count.There was no mechanism to exclude specific job names — the existing
--ignoreflag only filters Jira bug keys.Tracked by OCPEDGE-3050 and OCPEDGE-3046.
Changes
plugins/shared/scripts/prow-jobs-for-release.sh: Addedapply_exclusions()function that reads an optionalexcluded-jobs.txtfrom the calling plugin's directory. Usesdirname "${BASH_SOURCE[0]}"(without resolving symlinks) so each plugin symlink picks up its own exclusion file. Backward compatible — when no file exists, output passes through unchanged.plugins/lvms-ci/scripts/excluded-jobs.txt: Lists the 8 disabled LVMS 5.1 QE integration test job substrings (disabled until OCPEDGE-2977 is fixed).plugins/microshift-ci/scripts/excluded-jobs.txt: Template file with format documentation and no active exclusions (ready for use when needed).How It Works
excluded-jobs.txtis a substring matched against the full Prow job name#and empty lines are ignoredAI-generated. Review for accuracy.
@kasturinarra requested via Chai Bot
Summary by CodeRabbit
New Features
Improvements