CNF-26773: Remove minOffsetThreshold from PTP config source-crs and reference

[vitus133]

Remove the minOffsetThreshold field from ptpClockThreshold in all PtpConfig source-crs and the corresponding kube-compare-reference default_value.yaml examples.

Assisted by Claude

/cc @lack

[openshift-ci-robot]

@vitus133: This pull request references CNF-26773 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Remove the minOffsetThreshold field from ptpClockThreshold in all PtpConfig source-crs and the corresponding kube-compare-reference default_value.yaml examples.

Assisted by Claude

/cc @lack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitus133
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: fc180280-92b7-4da9-9685-f8a31a0feb5e

📥 Commits

Reviewing files that changed from the base of the PR and between b6d0690 and 42edcac.

📒 Files selected for processing (9)

• telco-ran/configuration/kube-compare-reference/hack/default_value.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigBoundaryForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigDualCardGmWpc.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigDualFollower.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigForHAForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigGmWpc.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigMasterForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigSlaveForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigThreeCardGmWpc.yaml

💤 Files with no reviewable changes (9)

• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigForHAForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigSlaveForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigDualFollower.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigDualCardGmWpc.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigMasterForEvent.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigThreeCardGmWpc.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigBoundaryForEvent.yaml
• telco-ran/configuration/kube-compare-reference/hack/default_value.yaml
• telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfigGmWpc.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes minOffsetThreshold: -100 from eight PTP operator profiles and the matching kube-compare reference entries. Other configured clock threshold fields remain unchanged.

Changes

PTP threshold configuration

Layer / File(s)	Summary
Update PTP source configurations telco-ran/configuration/source-crs/ptp-operator/configuration/PtpConfig*.yaml	Eight PTP profiles no longer define minOffsetThreshold. Existing clock threshold settings remain configured where applicable.
Synchronize comparison references telco-ran/configuration/kube-compare-reference/hack/default_value.yaml	The matching eight reference entries no longer define minOffsetThreshold: -100.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 42edc

This localized change removes an obsolete PTP configuration field from source examples and reference defaults; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: lack

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states that minOffsetThreshold is removed from the PTP source CRs and reference configuration.
Description check	✅ Passed	The description accurately summarizes the removal from all PTP source CRs and corresponding reference examples.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}