ART-23537: Fix hermetic build failure by removing update-bindata from build target

[redhat-chai-bot]

The build target in tests-extension/Makefile calls update-bindata,
which runs go install github.com/go-bindata/go-bindata/v3/go-bindata with
a pinned version. This fails in hermetic Konflux builds where network access
is blocked — Cachi2 only pre-fetches dependencies from go.mod/go.sum,
not tool installations via go install.

Since testdata/bindata.go is already committed and checked in,
regenerating it during the container image build is unnecessary.
The update-bindata target remains available for development use
when test fixtures are modified.

Fixes: ART-23537

---

AI-generated. Review for accuracy.

@joepvd requested via Chai Bot

Summary by CodeRabbit

• Chores
  • Simplified the extension test build process by removing the automatic bindata regeneration step.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d9eaf8b8-ebe0-4e0d-a908-1da1eade067f

📥 Commits

Reviewing files that changed from the base of the PR and between 3d991ed and 5fc2bdd.

📒 Files selected for processing (1)

• tests-extension/Makefile

💤 Files with no reviewable changes (1)

• tests-extension/Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The build target no longer runs bindata.mk update-bindata before building. The clean target remains unchanged.

Changes

Bindata Build

Layer / File(s)	Summary
Build target adjustment tests-extension/Makefile	Removed the bindata regeneration command from the build target. The clean-bindata command remains in the clean target.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5fc2b

No specific regression or merge-blocking behavior has been established for this change.

🚥 Pre-merge checks | ✅ 5 | ❌ 10

❌ Failed checks (10 inconclusive)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing update-bindata from the build target to fix hermetic build failures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.

---

_{Comment @coderabbitai help to get the list of available commands.}

[redhat-chai-bot]

/retitle ART-23537: Fix hermetic build failure by removing update-bindata from build target

---

AI-generated. Review for accuracy.

[openshift-ci-robot]

@redhat-chai-bot: This pull request references ART-23537 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

The build target in tests-extension/Makefile calls update-bindata,
which runs go install github.com/go-bindata/go-bindata/v3/go-bindata with
a pinned version. This fails in hermetic Konflux builds where network access
is blocked — Cachi2 only pre-fetches dependencies from go.mod/go.sum,
not tool installations via go install.

Since testdata/bindata.go is already committed and checked in,
regenerating it during the container image build is unnecessary.
The update-bindata target remains available for development use
when test fixtures are modified.

Fixes: ART-23537

---

AI-generated. Review for accuracy.

@joepvd requested via Chai Bot

Summary by CodeRabbit

• Chores
• Simplified the extension test build process by removing the automatic bindata regeneration step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[redhat-chai-bot]

Root cause: PR #485 (NE-2126: Migrating DNS operator test cases from QE repo) introduced tests-extension/Makefile which calls update-bindata during make build. This runs go install to fetch go-bindata from the network, which fails in the hermetic Konflux build environment where network access is blocked.

---

AI-generated. Review for accuracy.

[rikatz]

/lgtm
/approve
/cc @melvinjoseph86
as the original implementor

[joepvd]

/verified by working build after merge

[openshift-ci-robot]

@joepvd: This PR has been marked as verified by working build after merge.

Details

In response to this:

/verified by working build after merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-operator
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.