Repository navigation
[release-6.6] LOG-9759: pin journalctl_path in generated journald source - #3521
Conversation
The Vector journald source exposes an optional `journalctl_path`. When it is unset Vector performs a PATH search for the `journalctl` binary, and the field is config-controllable, so an injected config could point it at an attacker-placed binary and achieve arbitrary binary execution (LOG-9759 / FIND-003, CWE-73). Harden the operator-generated collector config by pinning `journalctl_path` to the trusted absolute path `/usr/bin/journalctl` (where journalctl ships in the collector image). The deployed collector no longer relies on a PATH search or a defaultable/overridable value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: LOG-9759 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/cluster-logging-operator/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/label verified |
openshift-ci
Bot
added
the
verified
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This is an automated cherry-pick of #3491
/assign jcantrill