Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/cluster-logging-operator/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vparfonov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest-required |
Enforce that the collector container runs as a fixed non-root UID (1000) with RunAsNonRoot=true. This removes unnecessary privilege from the collector workload and closes the CWE-250 (Execution with Unnecessary Privileges) finding. JIRA: LOG-9757 Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
9b57998 to
13e95b5
Compare
|
@vparfonov: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Enforce that the collector container runs as a fixed
non-root UID (1000)withRunAsNonRoot=true. This removes unnecessary privilege from the collector workload and closes the CWE-250 (Execution with Unnecessary Privileges) finding.Changes:
RunAsUser: 1000andRunAsNonRoot: trueto the collectorSecurityContextSecurityContextto bothDaemonSetandDeploymentcollector modesSCCfromRunAsAnytoMustRunAsNonRootto enforce at the policy level that all pods usinglogging-sccmustrun as non-root/cc
/assign @jcantrill
Links